Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed coding standard violations in the Framework\Locale namespace #9351

Merged
merged 2 commits into from
Apr 22, 2017
Merged

Fixed coding standard violations in the Framework\Locale namespace #9351

merged 2 commits into from
Apr 22, 2017

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented Apr 21, 2017

Fixed coding standard violations in the Framework\Locale namespace, s…o that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:

  • Removed @codingStandardsIgnoreFile from the head of the file
  • Fixed indentation
  • Fixed missing parameter in docblock comment

…o that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:

- Removed @codingStandardsIgnoreFile from the head of the file
- Fixed indentation
- Fixed missing parameter in docblock comment
@dverkade dverkade changed the title Fixed coding standard violations in the Framework\App namespace Fixed coding standard violations in the Framework\Locale namespace Apr 21, 2017
@okorshenko okorshenko self-assigned this Apr 22, 2017
@okorshenko okorshenko added this to the April 2017 milestone Apr 22, 2017
@magento-team magento-team merged commit 041ac3f into magento:develop Apr 22, 2017
magento-team pushed a commit that referenced this pull request Apr 22, 2017
@magento-team
Copy link
Contributor

@dverkade thank you for your contribution to Magento 2 project

@dverkade dverkade deleted the Fix_coding_standard_in_Framework-Locale branch June 22, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants