Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed coding standard violations in the Framework\Model namespace #9361

Merged
merged 3 commits into from
Jun 23, 2017
Merged

Fixed coding standard violations in the Framework\Model namespace #9361

merged 3 commits into from
Jun 23, 2017

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented Apr 22, 2017 •
edited by ishakhsuvarov
Loading

Fixed coding standard violations in the Framework\Model namespace, so that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:

  • Removed @codingStandardsIgnoreFile from the head of the file.
  • Fixed identation
  • Moves the Uut class to a file on its own.

@maghamed maghamed self-requested a review April 24, 2017 10:52
@maghamed maghamed self-assigned this Apr 24, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Jun 23, 2017
@ishakhsuvarov ishakhsuvarov added this to the June 2017 milestone Jun 23, 2017
@magento-team magento-team merged commit 3580757 into magento:develop Jun 23, 2017
magento-team pushed a commit that referenced this pull request Jun 23, 2017
@ishakhsuvarov
MAGETWO-70138: Fixed coding standard violations in the Framework\Mode…
b2b8be6 
…l namespace #9361
@dverkade dverkade deleted the Fix_coding_standard_in_Framework-Model branch June 22, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maghamed maghamed Awaiting requested review from maghamed

Assignees

@maghamed maghamed

@ishakhsuvarov ishakhsuvarov

Labels
None yet
Projects
None yet
Milestone
June 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@dverkade @magento-team @maghamed @ishakhsuvarov