Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a name to the Composite\Fieldset\Options block directive #9409

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Add a name to the Composite\Fieldset\Options block directive #9409

merged 1 commit into from
Jun 6, 2017

Conversation

navarr
Copy link
Member

@navarr navarr commented Apr 26, 2017

Add the name "product.composite.fieldset.options" to Composite\Fieldset\Options block so that third party custom options can add their own values without re-declaring the product.composite.fieldset directive.

Description

The block modified in this PR needs to have a name so that it can be referenced from third party modules wishing to create their own custom options.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Add the name "product.composite.fieldset.options" to Composite\Fieldset\Options block so that third party custom options can add their own values without re-declaring the product.composite.fieldset directive.
@ishakhsuvarov ishakhsuvarov self-assigned this Apr 27, 2017
@ishakhsuvarov ishakhsuvarov added this to the April 2017 milestone Apr 27, 2017
@okorshenko okorshenko modified the milestones: April 2017, May 2017 May 9, 2017
@okorshenko okorshenko modified the milestones: May 2017, June 2017 Jun 1, 2017
@navarr
Copy link
Member Author

navarr commented Jun 2, 2017

This was modified to "Response Needed" but nothing was asked here - does that mean an internal response is necessary (e.g. still out of my hands?)

@ishakhsuvarov
Copy link
Contributor

@navarr Looks like it was a mistake on my side. Thank you for bumping this. We are proceeding with this PR.

@magento-team magento-team merged commit 47f4424 into magento:develop Jun 6, 2017
@magento-team
Copy link
Contributor

@navarr thank you for your contribution. Your Pull Request has been successfully merged

@navarr navarr deleted the patch-5 branch June 13, 2017 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants