Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loadPlayer requirejs mapping #9414

Merged
merged 1 commit into from
Apr 30, 2017
Merged

Use loadPlayer requirejs mapping #9414

merged 1 commit into from
Apr 30, 2017

Conversation

ntoombs19
Copy link

@ntoombs19 ntoombs19 commented Apr 26, 2017

There is no reason for this module to use the path to the file when there exists a path mapping to the file within the requirejs-config.js file in this module.

There is no reason for this module to use the path to the file when there exists a path mapping to the file within the requirejs-config.js file in this module.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 26, 2017

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov self-assigned this Apr 27, 2017
@ishakhsuvarov ishakhsuvarov added this to the April 2017 milestone Apr 27, 2017
@magento-team magento-team merged commit 824cf1d into magento:develop Apr 30, 2017
magento-team pushed a commit that referenced this pull request Apr 30, 2017
[EngCom] Public Pull Requests

 - MAGETWO-67723: Add logging to contact us form #9343
 - MAGETWO-67721: Remove context aggregation validation (see Issue #6114) #8955
 - MAGETWO-68767: Use loadPlayer requirejs mapping #9414
 - MAGETWO-68770: Fix addIdFilter method #9400
@magento-team
Copy link
Contributor

@ntoombs19 thank you for your contribution to Magento 2 project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants