-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #7988 Typo changed also added comments for each index, getters and setters. #9484
Closed
Closed
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
90ebccb
#7988 Typo in billingAddressFromData changed
arshad-codilar 5bc1a22
magento/magento2#7988 Added commnets in file checkout-data.js - added…
arshad-codilar e3b22e4
magento/magento2#7988 Requested changes updated also reverted last up…
arshad-codilar 73ac8c4
magento/magento2#7988 Changed typo pullled to pulled
arshad-codilar cc9778b
Merge branch 'develop' into develop
arshadpkm 85aec9d
Merge remote-tracking branch 'upstream/develop' into develop
arshad-codilar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,20 +33,24 @@ define([ | |
|
||
if ($.isEmptyObject(getData())) { | ||
checkoutData = { | ||
'selectedShippingAddress': null, | ||
'shippingAddressFromData': null, | ||
'newCustomerShippingAddress': null, | ||
'selectedShippingRate': null, | ||
'selectedPaymentMethod': null, | ||
'selectedBillingAddress': null, | ||
'billingAddressFormData': null, | ||
'newCustomerBillingAddress': null | ||
'selectedShippingAddress': null, // Selected shipping address pullled from local storage (Persistence) | ||
'shippingAddressFromData': null, // Shipping address pullled from local storage (Persistence) | ||
'newCustomerShippingAddress': null, // Shipping address pullled from local storage for new customer (Persistence) | ||
'selectedShippingRate': null, // Shipping rate pulled from local storage (Persistence) | ||
'selectedPaymentMethod': null, // Payment method pulled from local storage (Persistence) | ||
'selectedBillingAddress': null, // Selected billing address pullled from local storage (Persistence) | ||
'billingAddressFromData': null, // Billing address pullled from local storage (Persistence) | ||
'newCustomerBillingAddress': null, // Billing address pullled from local storage for new customer (Persistence) | ||
'validatedEmailValue': null, // Validated email address from local storage (Persistence) | ||
'inputFieldEmailValue' : null // Email input field value from local storage (Persistence) | ||
}; | ||
saveData(checkoutData); | ||
} | ||
|
||
return { | ||
/** | ||
* Setting the selected shipping address pulled from local storage | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add . at the end of the comment. (all cases) |
||
* | ||
* @param {Object} data | ||
*/ | ||
setSelectedShippingAddress: function (data) { | ||
|
@@ -57,13 +61,17 @@ define([ | |
}, | ||
|
||
/** | ||
* Pulling the selected shipping address from local storage | ||
* | ||
* @return {*} | ||
*/ | ||
getSelectedShippingAddress: function () { | ||
return getData().selectedShippingAddress; | ||
}, | ||
|
||
/** | ||
* Setting the shipping address pulled from local storage | ||
* | ||
* @param {Object} data | ||
*/ | ||
setShippingAddressFromData: function (data) { | ||
|
@@ -74,13 +82,17 @@ define([ | |
}, | ||
|
||
/** | ||
* Pulling the shipping address from local storage | ||
* | ||
* @return {*} | ||
*/ | ||
getShippingAddressFromData: function () { | ||
return getData().shippingAddressFromData; | ||
}, | ||
|
||
/** | ||
* Setting the shipping address pulled from local storage for new customer | ||
* | ||
* @param {Object} data | ||
*/ | ||
setNewCustomerShippingAddress: function (data) { | ||
|
@@ -91,13 +103,17 @@ define([ | |
}, | ||
|
||
/** | ||
* Pulling the shipping address from local storage for new customer | ||
* | ||
* @return {*} | ||
*/ | ||
getNewCustomerShippingAddress: function () { | ||
return getData().newCustomerShippingAddress; | ||
}, | ||
|
||
/** | ||
* Setting the selected shipping rate pulled from local storage | ||
* | ||
* @param {Object} data | ||
*/ | ||
setSelectedShippingRate: function (data) { | ||
|
@@ -108,13 +124,17 @@ define([ | |
}, | ||
|
||
/** | ||
* Pulling the selected shipping rate from local storge | ||
* | ||
* @return {*} | ||
*/ | ||
getSelectedShippingRate: function () { | ||
return getData().selectedShippingRate; | ||
}, | ||
|
||
/** | ||
* Setting the selected payment method pulled from local storage | ||
* | ||
* @param {Object} data | ||
*/ | ||
setSelectedPaymentMethod: function (data) { | ||
|
@@ -125,13 +145,17 @@ define([ | |
}, | ||
|
||
/** | ||
* Pulling the payment method from local storage | ||
* | ||
* @return {*} | ||
*/ | ||
getSelectedPaymentMethod: function () { | ||
return getData().selectedPaymentMethod; | ||
}, | ||
|
||
/** | ||
* Setting the selected billing address pulled from local storage | ||
* | ||
* @param {Object} data | ||
*/ | ||
setSelectedBillingAddress: function (data) { | ||
|
@@ -142,13 +166,17 @@ define([ | |
}, | ||
|
||
/** | ||
* Pulling the selected billing address from local storage | ||
* | ||
* @return {*} | ||
*/ | ||
getSelectedBillingAddress: function () { | ||
return getData().selectedBillingAddress; | ||
}, | ||
|
||
/** | ||
* Setting the billing address pulled from local storage | ||
* | ||
* @param {Object} data | ||
*/ | ||
setBillingAddressFromData: function (data) { | ||
|
@@ -159,13 +187,16 @@ define([ | |
}, | ||
|
||
/** | ||
* Pulling the billing address from local storage | ||
* @return {*} | ||
*/ | ||
getBillingAddressFromData: function () { | ||
return getData().billingAddressFromData; | ||
}, | ||
|
||
/** | ||
* Setting the billing address pulled from local storage for new customer | ||
* | ||
* @param {Object} data | ||
*/ | ||
setNewCustomerBillingAddress: function (data) { | ||
|
@@ -176,13 +207,17 @@ define([ | |
}, | ||
|
||
/** | ||
* Pulling the billing address from local storage for new customer | ||
* | ||
* @return {*} | ||
*/ | ||
getNewCustomerBillingAddress: function () { | ||
return getData().newCustomerBillingAddress; | ||
}, | ||
|
||
/** | ||
* Pulling the email address from local storage | ||
* | ||
* @return {*} | ||
*/ | ||
getValidatedEmailValue: function () { | ||
|
@@ -192,6 +227,8 @@ define([ | |
}, | ||
|
||
/** | ||
* Setting the email address pulled from local storage | ||
* | ||
* @param {String} email | ||
*/ | ||
setValidatedEmailValue: function (email) { | ||
|
@@ -202,6 +239,8 @@ define([ | |
}, | ||
|
||
/** | ||
* Pulling the email input field value from local storage | ||
* | ||
* @return {*} | ||
*/ | ||
getInputFieldEmailValue: function () { | ||
|
@@ -211,6 +250,8 @@ define([ | |
}, | ||
|
||
/** | ||
* Setting the email input field value pulled from local storage | ||
* | ||
* @param {String} email | ||
*/ | ||
setInputFieldEmailValue: function (email) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in my new commit