Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #9646 #9647

Merged
merged 1 commit into from
May 19, 2017
Merged

Fix for #9646 #9647

merged 1 commit into from
May 19, 2017

Conversation

ekuusela
Copy link
Contributor

@ekuusela ekuusela commented May 16, 2017 •
edited by okorshenko
Loading

Allow extension attributes for quote addresses. See a fix for a similar issue here: 8e0c8a6

Description

Unset the address extension attributes before trying to create the quote totals.

Fixed Issues (if relevant)

  1. CartTotalRepository cannot handle extension attributes in quote addresses #9646

Manual testing scenarios

From the linked issue:

  1. define extension attributes for the quote billing address
  2. login as a user who has at least two addresses in his address book
  3. add a virtual product to card and proceed to checkout
  4. choose or change the billing address, click update, note no errors.

@ekuusela
Fix for #9646
aa535ea 
Allow extension attributes for quote addresses. See a fix for a similar issue here: 8e0c8a6
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 16, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@okorshenko okorshenko self-assigned this May 16, 2017
@okorshenko okorshenko added this to the May 2017 milestone May 16, 2017
@magento-team magento-team merged commit aa535ea into magento:2.1-develop May 19, 2017
magento-team pushed a commit that referenced this pull request May 19, 2017
@ishakhsuvarov
MAGETWO-69223: Fix for #9646 #9647
9ac5a2a
magento-team pushed a commit that referenced this pull request May 19, 2017
@ishakhsuvarov
Merge pull request #1120 from magento-engcom/2.1-develop-prs
e1e4617 
[EngCom] Public Pull Requests - 2.1
 - MAGETWO-69238: Keep transparency when resizing images [2.1 backport] #9662
 - MAGETWO-69236: Add configurations for change email templates [2.1 backport] #9661
 - MAGETWO-69235: Do not di:compile tests/ folder #9660
 - MAGETWO-69223 Fix for #9646 #9647
 - MAGETWO-69234: Backport of MAGETWO-69152: Removed workaround for old Webkit bug #9655
@magento-team
Copy link
Contributor

@ekuusela thank you for your contribution to Magento 2 project

@ekuusela ekuusela deleted the patch-1 branch May 19, 2017 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
Release Line: 2.1
Projects
None yet
Milestone
May 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@ekuusela @magento-cicd2 @magento-team @Vikram0811 @okorshenko