Fix for javascript "mixins" when 'urlArgs' is set in requirejs-config.js - issue 8221 #9664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem where if you add a "urlArgs" argument to a requirejs-config.js file, javascript mixins will stop working. For example if you add the line :
urlArgs:urlArgs: "bust=2017-04-21"
to Magento_Theme/templates/page/js/require_js.phtml - this will stop mixins.js from working.
See issue #8221
Description
The problem is due to 'urlArgs' adding a query string to the path variable. The function getMixins in mixins.js tries to reference config using the path variable, but as this includes the query string, it fails.
This change removes the query string from the path variable, allowing config to be referenced correctly.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist