Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts.js #9686

Merged
merged 1 commit into from
May 24, 2017
Merged

Update scripts.js #9686

merged 1 commit into from
May 24, 2017

Conversation

redelschaap
Copy link
Contributor

@redelschaap redelschaap commented May 18, 2017

Got an error Uncaught TypeError: Cannot read property 'value' of undefined when the customer group setting was not present on the order create page in the admin.

Description

Got an error Uncaught TypeError: Cannot read property 'value' of undefined when the customer group setting was not present on the order create page in the admin. This is the case when reordering an order for a guest. This fix checks whether the field can be found first.

Manual testing scenarios

  1. Open a guest's order
  2. Reorder that order
  3. Fill in a VAT number and click on Validate
  4. The validation is now executed, while without this fix an error would be thrown in the console.

@vrann vrann self-assigned this May 19, 2017
@vrann vrann added this to the May 2017 milestone May 19, 2017
@vrann vrann added the develop label May 19, 2017
@magento-team magento-team merged commit 34a1e35 into magento:develop May 24, 2017
magento-team pushed a commit that referenced this pull request May 24, 2017
@vrann
Copy link
Contributor

vrann commented May 24, 2017

@redelschaap thank you, merged!

@magento-team
Copy link
Contributor

@redelschaap thank you for your contribution. Your Pull Request has been successfully merged

@redelschaap
Copy link
Contributor Author

You're welcome! Happy to help!

@redelschaap redelschaap deleted the patch-9 branch May 25, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants