Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new CLI command: Enable Template Hints #9778

Merged
merged 4 commits into from
Jun 7, 2017
Merged

new CLI command: Enable Template Hints #9778

merged 4 commits into from
Jun 7, 2017

Conversation

miguelbalparda
Copy link
Contributor

@miguelbalparda miguelbalparda commented May 29, 2017

In order to help developers to work with the Magento CLI, create new commands which will simplify the debugging of the application. Currently, enabling of these setting require doing that either with the UI or changing the configuration of the di.xml.

Description

Added a CLI switch to enable/disable template hints.

Fixed Issues (if relevant)

  1. Create new CLI command: Enable Template Hints #9278 Create new CLI command: Enable Template Hints

Manual testing scenarios

  1. php bin/magento dev:template-hints:enable
  2. Check for dev/debug/template_hints_storefront to be 1
  3. php bin/magento dev:template-hints:disable
  4. Check for dev/debug/template_hints_storefront to be 0

*. A cache flush is required both from the CLI and from the web UI after template paths are enabled/disabled in order for the hints to show. This should probably be in the success message, not really sure how to word it.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Submitted at #mm17se contribution day

@okorshenko okorshenko self-assigned this May 29, 2017
@okorshenko okorshenko added this to the May 2017 milestone May 29, 2017
@miguelbalparda
Copy link
Contributor Author

@okorshenko this is ready from my side, I'll try to keep working on this later to add an extra parameter for the scope but for now this is it.

@okorshenko okorshenko modified the milestones: May 2017, June 2017 Jun 1, 2017
@magento-team magento-team merged commit 40a4275 into magento:develop Jun 7, 2017
magento-team pushed a commit that referenced this pull request Jun 7, 2017
@magento-team
Copy link
Contributor

@miguelbalparda thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants