Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#7291] Change the default contact form email template to HTML #9786

Merged

Conversation

VincentMarmiesse
Copy link
Contributor

@VincentMarmiesse VincentMarmiesse commented May 29, 2017

Hello,

I don't know if there is a reason for that, but having the contact form email in plain text is not really nice and it makes it difficult to override.

Description

So just a few changes here:

  • move the submitted_form.html template from adminhtml to frontend
  • include header and footer in this template
  • change the template's declaration into the email_templates.xml file to set type to html and area to frontend

Fixed Issues (if relevant)

  1. E-mail after Contact Us not in default e-mail layout (plain text) #7291

Manual testing scenarios

  1. Go to the contact form and send a mail
  2. Check the mail has the default footer and header

I'm open to discussion on this point if it's done on purpose.

Thanks.

@VincentMarmiesse VincentMarmiesse changed the title Change the default contact form email template to HTML [#7291] Change the default contact form email template to HTML May 29, 2017
@PieterCappelle
Copy link
Contributor

👍🏻

@okorshenko okorshenko self-assigned this Jun 5, 2017
@okorshenko okorshenko added this to the June 2017 milestone Jun 5, 2017
@vherasymenko
Copy link

vherasymenko commented Jun 14, 2017

@VincentMarmiesse Hi. After checkout your PR i try send mail using contact form.
On attachment displayed result of received message. There are no correct message
33
Maybe I need do something else steps than written in your PR ??

magento-team pushed a commit that referenced this pull request Jun 20, 2017
@magento-team magento-team merged commit 56fa817 into magento:develop Jun 22, 2017
magento-team pushed a commit that referenced this pull request Jun 22, 2017
… to HTML #9786

 - reverted HTML markup. Markup can be added as a customization but we should not ship markup out-of-the-box
magento-team pushed a commit that referenced this pull request Jun 22, 2017
magento-team pushed a commit that referenced this pull request Jun 22, 2017
… to HTML #9786

 - fixed issue with current store id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants