Update regex in menu.xsd #982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regex should be equal to this https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/Module/etc/module.xsd#L76. Otherwhise you are not able to use camelcase in your vendorname.
|
... unittests are failing, i will fix that asap. |
magento-team
pushed a commit
that referenced
this pull request
Mar 31, 2017
MAGETWO-65801: Remove usages of unserialize in module /Magento/Setup/. CE - missed usages
magento-team
pushed a commit
that referenced
this pull request
Dec 12, 2017
…iting Order shipping/billing address - allowed countries are selected from wrong Store View #982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex should be equal to this https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/Module/etc/module.xsd#L76.
Otherwhise you are not able to use camelcase in your vendorname.