suggestion from #9338: add some command/option to the deploy command to refresh the version #9915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In production environments with a CDN for static files it comes in handy that you can force a browser cache refresh by changing the number manually without having to go into maintenance for a full deploy.
If you edit the `pub/static/deployed_version.txt` with vim, nano or `echo '123456789' > pub/static/deployed_version.txt` you can unintentionally create a newline at the end of the file.
This will result in:
```html
var BASE_URL = 'https://magento2.dev/sitemanager/admin/index/index/key/ec38dd3ded42b71db14166d6bcdfc56d4e7d4b7801b9808373ae4b3563b65513/';
var FORM_KEY = 'dKArsQU6NhimXr6Z';
var require = {
"baseUrl": "https://magento2.dev/pub/static/version1492766286
/adminhtml/Magento/backend/en_US"
};
```
With that baseUrl all resources using baseUrl will return the 404 page.
Adding a simple `trim()` here will remove that risk.
This reverts commit 78aba16.
With this option you can quickly force a browser cache refresh or a CDN cache refresh without having to generate all static content. This comes in handy especially when you have made no code changes, but the CDN failed to update it's cache the last time you deployed or when you have made a manual change in one of the static files as a hotfix on your deployment server, awaiting a suitable moment for deployment to finalize it. This reopens magento#9338.
|
@ishakhsuvarov I will fix the unit test today |
magento-team
pushed a commit
that referenced
this pull request
Jun 15, 2017
…deploy command to refresh the version #9915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@ishakhsuvarov suggested to replace PR #9338 with an option to the
bin/magento setup:static-content:deploycommand that only updates the version of the generated files.This is in favour of editing the
pub/static/deployed_version.txtmanually.This comes in handy when a CDN server is out-of-sync or when you want to hotfix a file in deployed code and you want to force a browser cache refresh. This buys you time to deploy the hotfix in a proper way at a moment that is better suited for downtime.
Fixed Issues (if relevant)
Manual testing scenarios
bin/magento setup:static-content:deploy -f --content-version="123456" --refresh-content-version-onlyContribution checklist