Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make page title in layout files translatable #9992

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

AntonEvers
Copy link
Contributor

@AntonEvers AntonEvers commented Jun 20, 2017

Description

Make it possible to translate page titles that are provided in the layout xml files.

Fixed Issues (if relevant)

  1. Not able to translate page layout head titles #6337: Not able to translate page layout head titles

Manual testing scenarios

  1. translate one of the page titles that have been altered in this pull request
  2. flush the cache
  3. visit the page
  4. see that the title is translated

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda self-assigned this Jun 20, 2017
@miguelbalparda miguelbalparda added this to the June 2017 milestone Jun 20, 2017
@miguelbalparda
Copy link
Contributor

Hi @ajpevers, thanks for the PR! I just re run the tests and they appear to be all green now, will get back to you in case we have any questions.

@miguelbalparda
Copy link
Contributor

miguelbalparda commented Jun 26, 2017

@ajpevers from the internal automated testing we got

Function __() is defined outside of the library and must not be used there. Replacement suggestion: new \Magento\Framework\Phrase()

Can you adapt this PR to that suggestion?
Thanks!

@AntonEvers
Copy link
Contributor Author

Sure! I'm on a holiday right now but I will get back to you.

@okorshenko
Copy link
Contributor

Hi @ajpevers we fixed this issue on our side. Thank you

@magento-team magento-team merged commit 88b9a16 into magento:develop Jun 29, 2017
magento-team pushed a commit that referenced this pull request Jun 29, 2017
@AntonEvers AntonEvers deleted the translate-head-title branch July 6, 2017 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants