Fix mini-cart not emptied for logged out users checking out with PayPal Express #9994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al Express *Problem* When checking out of M2 using PayPal Express as a logged in user, the mini-cart is not emptied after you reach the success page. In fact, you'll still have the same cart contents in the mini-basket as you purchased. As soon as you add a new item to the basket it does then reset and only shows the new items (old contents are gone). This is, however, confusing, as clicking the mini-cart then proceeding to cart of course shows "No items in the cart". *Investigation and Solution* Investigating the issue, we found that during checkout as logged in user, the `paypal-express-abstract.js` code correctly invalidates the `cart` `customerData` component. However, it is almost immediately afterwards reloaded, and of course, as this is before we pass out to PayPal, the cart is reloaded with the same contents. Upon then proceeding to PayPal and returning, there is no further invalidation and nothing is reloaded. This does not occur for guests. I discovered this is due to a `sections.xml` entry existing for the AJAX request that `set-payment-method.js` makes for logged in users. No such entry exists for guests. This entry includes `cart` and as such invalidates and reloads `cart`, whereas the desired behaviour is to only invalidate, and not reload until success page is reached. I determined that there are two modules providing API for setting payment information, `Magento_Quote` and `Magento_Checkout`. The former, `Magento_Quote` has entries in `sections.xml` to invalidate the `cart` data. It seems in the PayPal JS code it is using `Magento_Checkout` for guests and `Magento_Quote` for logged in users. By modifying this to use `Magento_Checkout` APIs for both (as one would likely expect) the issue is resolved, as there are no `sections.xml` entries for these APIs.
|
|
|
CLA signed |
magento-team
pushed a commit
that referenced
this pull request
Jun 21, 2017
…g out with PayPal Express #9994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When checking out of M2 using PayPal Express as a logged in user, the mini-cart is not emptied after you reach the success page. In fact, you'll still have the same cart contents in the mini-basket as you purchased. As soon as you add a new item to the basket it does then reset and only shows the new items (old contents are gone). This is, however, confusing, as clicking the mini-cart then proceeding to cart of course shows "No items in the cart".
There are two modules providing API for setting payment information,
Magento_QuoteandMagento_Checkout. The former,Magento_Quotehas entries insections.xmlto invalidate and reload thecartdata. In this code it is usingMagento_Checkoutfor guests andMagento_Quotefor logged in users, causing logged in users to have theircartdata reloaded too early, before the cart is in fact reset, and causing it to persist after checkout is completed. By modifying this to useMagento_CheckoutAPIs for both (as one would likely expect) the issue is resolved, as there are nosections.xmlentries for theMagenta_CheckoutAPIs.This PR also introduces consistency as the same module API is used for both types of users.
I'm unsure how to make integration tests for this.
Manual testing scenarios
Before PR: You will see items still in mini-cart even though you bought them
After PR: You will see an empty mini-cart
Contribution checklist