Merge pull request #4064 from glo71317/PWA-3065

Pwa 3065::When the button "sign in" is pressed by the keyboard, nothing happens.
magento · Mar 24, 2023 · 32307d4 · 32307d4
2 parents 1e420d3 + c36d345
commit 32307d4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/packages/peregrine/lib/talons/SignIn/__tests__/useSignIn.spec.js b/packages/peregrine/lib/talons/SignIn/__tests__/useSignIn.spec.js
@@ -131,6 +131,7 @@ test('returns correct shape', () => {
             "shouldRender": false,
           },
           "setFormApi": [Function],
+          "signinHandleEnterKeyPress": [Function],
         }
     `);
 });

diff --git a/packages/peregrine/lib/talons/SignIn/useSignIn.js b/packages/peregrine/lib/talons/SignIn/useSignIn.js
@@ -81,6 +81,7 @@ export const useSignIn = props => {
                     },
                     ...recaptchaData
                 });
+
                 const token = signInResponse.data.generateCustomerToken.token;
                 await setToken(token);
 
@@ -173,6 +174,14 @@ export const useSignIn = props => {
         };
     }, [handleCreateAccount]);
 
+    const signinHandleEnterKeyPress = useCallback(() => {
+        event => {
+            if (event.key === 'Enter') {
+                handleSubmit();
+            }
+        };
+    }, [handleSubmit]);
+
     const errors = useMemo(
         () =>
             new Map([
@@ -186,6 +195,7 @@ export const useSignIn = props => {
         errors,
         handleCreateAccount,
         handleEnterKeyPress,
+        signinHandleEnterKeyPress,
         handleForgotPassword,
         handleSubmit,
         isBusy: isGettingDetails || isSigningIn || recaptchaLoading,

diff --git a/packages/venia-ui/lib/components/SignIn/signIn.js b/packages/venia-ui/lib/components/SignIn/signIn.js
@@ -37,6 +37,7 @@ const SignIn = props => {
         errors,
         handleCreateAccount,
         handleEnterKeyPress,
+        signinHandleEnterKeyPress,
         handleForgotPassword,
         handleSubmit,
         isBusy,
@@ -119,6 +120,7 @@ const SignIn = props => {
                     <Button
                         priority="high"
                         type="submit"
+                        onKeyDown={signinHandleEnterKeyPress}
                         data-cy="SignInButton-root_highPriority"
                         disabled={isBusy}
                     >
-Original file line number
+Diff line change
@@ Expand Up / @@ -131,6 +131,7 @@ test('returns correct shape', () => { @@
                 "shouldRender": false,
               },
               "setFormApi": [Function],
+              "signinHandleEnterKeyPress": [Function],
             }
         `);
     });
@@ Expand Down @@