Skip to content

Commit

Permalink
BUG#AC_2495::Items within actions menu receive keyboard focus when no… (
Browse files Browse the repository at this point in the history
#3800)

* BUG#AC_2495::Items within actions menu receive keyboard focus when not visible.

* AC-2495::added updated product.spec.js.snap and kebab.spec.js.snap

Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
  • Loading branch information
glo82145 and dpatil-magento authored Jul 18, 2022
1 parent 404d00d commit 52838a2
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ exports[`renders configurable product with options 1`] = `
</span>
</button>
<ul
aria-hidden="true"
className="dropdown"
>
<li
Expand Down Expand Up @@ -593,6 +594,7 @@ exports[`renders out of stock product 1`] = `
</span>
</button>
<ul
aria-hidden="true"
className="dropdown"
>
<li
Expand Down Expand Up @@ -892,6 +894,7 @@ exports[`renders simple product correctly 1`] = `
</span>
</button>
<ul
aria-hidden="true"
className="dropdown"
>
<li
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ exports[`it renders children passed to it 1`] = `
}
/>
</button>
<ul>
<ul
aria-hidden="true"
>
<span />
<p />
<div />
Expand All @@ -44,6 +46,8 @@ exports[`it renders correctly without children 1`] = `
}
/>
</button>
<ul />
<ul
aria-hidden="true"
/>
</div>
`;
4 changes: 3 additions & 1 deletion packages/venia-ui/lib/components/LegacyMiniCart/kebab.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ const Kebab = props => {
>
<Icon src={MoreVerticalIcon} />
</button>
<ul className={toggleClass}>{children}</ul>
<ul aria-hidden="true" className={toggleClass}>
{children}
</ul>
</div>
);
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,12 @@
transition: 256ms ease-out;
transform: scale(0);
transform-origin: 100% 0;
display: none !important;
}

.dropdown_active {
composes: dropdown;

display: block !important;
composes: absolute from global;
transform: scale(1);
transition: 250ms var(--venia-global-anim-bounce);
Expand Down

0 comments on commit 52838a2

Please sign in to comment.