Merge pull request #4102 from magento/PWA-3080

PWA-3080:: When you click on Thumbnail, Add to cart works
magento · May 16, 2023 · 8c07d6b · 8c07d6b
2 parents 9f524e8 + 35e41e2
commit 8c07d6b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/...enia-ui/lib/components/ProductImageCarousel/__tests__/__snapshots__/carousel.spec.js.snap b/...enia-ui/lib/components/ProductImageCarousel/__tests__/__snapshots__/carousel.spec.js.snap
@@ -244,6 +244,7 @@ exports[`renders the Carousel component correctly w/ sorted images 1`] = `
       aria-label="Current Image"
       className="rootSelected"
       onClick={[Function]}
+      type="button"
     >
       <div
         className="root container"
@@ -294,6 +295,7 @@ exports[`renders the Carousel component correctly w/ sorted images 1`] = `
       aria-label="Next Image"
       className="root"
       onClick={[Function]}
+      type="button"
     >
       <div
         className="root container"
@@ -344,6 +346,7 @@ exports[`renders the Carousel component correctly w/ sorted images 1`] = `
       aria-label="Next Image"
       className="root"
       onClick={[Function]}
+      type="button"
     >
       <div
         className="root container"
@@ -394,6 +397,7 @@ exports[`renders the Carousel component correctly w/ sorted images 1`] = `
       aria-label="Next Image"
       className="root"
       onClick={[Function]}
+      type="button"
     >
       <div
         className="root container"

diff --git a/...nia-ui/lib/components/ProductImageCarousel/__tests__/__snapshots__/thumbnail.spec.js.snap b/...nia-ui/lib/components/ProductImageCarousel/__tests__/__snapshots__/thumbnail.spec.js.snap
@@ -5,6 +5,7 @@ exports[`renders root class if not the active Thumbnail 1`] = `
   aria-label="Next Image"
   className="root"
   onClick={[Function]}
+  type="button"
 >
   <div
     className="root container"
@@ -58,6 +59,7 @@ exports[`renders the Thumbnail component correctly 1`] = `
   aria-label="Current Image"
   className="rootSelected"
   onClick={[Function]}
+  type="button"
 >
   <div
     className="root container"
@@ -111,6 +113,7 @@ exports[`renders transparent placeholder when no file name is provided 1`] = `
   aria-label="Current Image"
   className="rootSelected"
   onClick={[Function]}
+  type="button"
 >
   <div
     className="root container"

diff --git a/packages/venia-ui/lib/components/ProductImageCarousel/thumbnail.js b/packages/venia-ui/lib/components/ProductImageCarousel/thumbnail.js
@@ -67,6 +67,7 @@ const Thumbnail = props => {
 
     return (
         <button
+            type="button"
             className={isActive ? classes.rootSelected : classes.root}
             onClick={handleClick}
             aria-label={selectedItem}