Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Display page level error and disable checkout button when no available payment methods #2869

Closed
sirugh opened this issue Nov 19, 2020 · 7 comments · Fixed by #2873
Assignees
Labels
enhancement New feature or request Progress: done

Comments

@sirugh
Copy link
Contributor

sirugh commented Nov 19, 2020

If you setup Magento locally and then try to purchase a product you'll see a broken payment method on the checkout and you'll be unable to submit the checkout further.

Replication Steps:

  • Install Magento 2.3.5-p1 using composer, install Venia sample data
  • On latest develop point your instance to the new composer installation
  • Ensure you have the CHECKOUTBRAINTREETOKEN set to something valid
  • Navigate to a product page, add it to cart, then visit /checkout
  • Complete the shipping address and method
  • (x) Notice the payment method is skipped and renders as an empty box and pressing "Review Order" disables the button but nothing happens (After [feature]: Display "no payment method available" message if no allowed or configured payment methods are present #2855 there will be an error message instead of empty box)

![](Screen Shot 2020-06-04 at 11.12.22 AM.png)

Acceptance Criteria

Test Plan

  • Verify error message is displayed in the Payment Information section, when no payment methods are available
  • Verify error message is displayed at the page level, when no payment methods are available
  • Verify the "Review Order" button is disabled when no payment methods are available

Developer Notes

  • I'm not sure how to repro the issue with invalid backend config, but you can repro in checkout by turning availablePaymentMethods into an empty array in your local code. A page level error and disabling the review order button will take some additional queries to check for valid methods at the checkout page level.
@sirugh sirugh added the enhancement New feature or request label Nov 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2020

Hi @sirugh. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@ankurvr
Copy link
Member

ankurvr commented Nov 24, 2020

@sirugh As per the screenshot shown the title "Checkout" (check below) is not there in current design. Do you want me to add that too?
Screen Shot 2020-11-24 at 2 47 49 PM

@ankurvr
Copy link
Member

ankurvr commented Nov 24, 2020

@sirugh Can you please also verify and approve the form error message for Guest user and Logged in user both in terms of UI?

pwa-docker localhost_8080_checkout (2)
pwa-docker localhost_8080_checkout (1)

@sirugh
Copy link
Contributor Author

sirugh commented Jan 19, 2021

@magento export issue to Jira project PWA as Story

@magento-engcom-team
Copy link

✅ Jira issue (https://jira.corp.magento.com/browse/PWA-1280) is successfully created for this issue.

@ankurvr
Copy link
Member

ankurvr commented Jan 20, 2021

@sirugh Can i still continue working on this issue after after creating internal Jira ticket? Or it will be taken care by Magento team from here?

@sirugh
Copy link
Contributor Author

sirugh commented Jan 20, 2021

You can still work on this, of course! Can you rebase and handle the merge conflicts? Also there was some initial feedback given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Progress: done
Projects
None yet
4 participants