[feature]: Display "no payment method available" message if no allowed or configured payment methods are present #2855

ankurvr · 2020-11-10T11:21:22Z

Description

It's not showing message when there are no supported payment methods available.
It's becoming and empty container instead of showing proper message.

Related Issue

Closes #2854.
PWA-1115

Acceptance

Verification Stakeholders

Specification

Verification Steps

Make sure you have braintree payment method disabled and other payment methods like Purchase order, bank transfer enabled.
Add any product to cart
Go to Cart -> Checkout
Add shipping address and select any shipping method
Let it load the payment methods from server. After loading completion payment method it should show the message.

Screenshots / Screen Captures (if appropriate)

Checklist

I have added tests to cover my changes, if necessary.
I have added translations for new strings, if necessary.
I have updated the documentation accordingly, if necessary.

Filtered payment method radios array because it was coming like [undefined, undefined]

Showing "No Payment method available." message when there are no supported payment methods available.

Created class to add padding to no payment method message

PWAStudioBot · 2020-11-10T11:34:00Z

	Fails
🚫	A version label is required. A maintainer must add one.

	Messages
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 36613c5

packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/paymentMethods.js

ankurvr

The requested change is done.

packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/paymentMethods.js

packages/venia-ui/i18n/en_US.json

packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/paymentMethods.js

packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/paymentMethods.css

sirugh · 2020-11-16T18:02:49Z

@ankurvr I opened an internal tracking ticket for the team to prioritize. You may not see movement on it for a bit, but I've given you some feedback that I think will capture most of the concerns with the PR. Please make changes when you can and we will take it from there.

ankurvr · 2020-11-17T02:42:21Z

@sirugh i will take care of the requested changes. Thanks

…on/paymentMethods.js Co-authored-by: Stephen <sirugh@users.noreply.github.com>

schensley · 2020-11-17T16:49:14Z

@ankurvr I am going off the screen shots provided here. The treatment is somewhat ambiguous, in that it looks like everything is responding as it should, but payments being 'offline' is actually a problem. I think this should be treated more like an error to help communicate that there is an issue.

ankurvr · 2020-11-18T05:25:53Z

@schensley Sorry i am bit confused with your comment.
Please correct me if i am wrong.
As per screenshot you want me to change the suggested functionality. Like message in red color in payments box and showing error message at top?

schensley · 2020-11-18T17:00:07Z

@ankurvr Sorry, I was trying to communicate the rationale behind the request for adding this "error" style messaging.
Yes, ideally a 2-part system of messaging, where there is a "headline" error message at the top, and a more specific (if possible) error message in the location of problem. The salient point being that the problem is highlighted for the shopper.

sirugh · 2020-11-18T18:47:59Z

@schensley unfortunately the checkout page does not have a page level error so that will be extra scope.

@ankurvr can you please just update the text to have color: rgb(var(--venia-global-color-error)); in the error case? If you want to tackle adding a page level error I will be happy to provide some guidance. Let me know.

ankurvr · 2020-11-19T04:38:49Z

@sirugh I have just updated the text message with error color you suggested.
It will look like below screenshot.

Also i will be happy to tackle adding page level error. Please guide me to achieve the same.

sirugh

Thanks for your work on this! We still need to get that page level error displayed, and disable the review button, but I've scoped that to a different internal ticket. If you'd like to work on that as well, let me know and I can open a github issue with relevant info.

Edit: I just saw you said you would be happy to tackle it. Let me discuss with the team and I'll follow up with you later.

sirugh · 2020-11-19T16:03:33Z

@ankurvr I have opened #2869 for you, with details. Let's continue the conversation in there if you have any questions :)

schensley · 2020-11-19T16:04:38Z

@ankurvr Great! Looks really good. Thank you. UX approved.

@sirugh I'm not sure the "Review" button should be disabled. If the shopper didn't notice the message or didn't understand it, if they can press the BTN (which shoppers seek) and it returns an error they might then take a closer look to see the issue is. No harm, we did try to tell them up front.

ankurvr · 2020-11-19T17:32:16Z

@sirugh @schensley Please update the final approach in the newly created task/ticket #2869 so i can proceed accordingly.

sirugh · 2020-11-19T19:10:17Z

@ankurvr not sure what you mean, I've added the desired solution and a mockup in the issue. Let's move questions over to that thread instead of adding more here :)

dpatil-magento · 2020-11-19T22:50:03Z

QA Approved.

@client

* [PWA-893] My Account: Order History - Remove @client directive (magento#2786) * Remove client directive and work through errors from using live data * Fixup region display so its not rendering ids * Fix payment method display and remove extra comma in addresses * Additional tweaks from UX feedback * Fixup failing tests * Fix couple tests failing after gql move * Fix bug where tracking information doesn't exist for shipped order * Updated Intl FormattedMessage component mock. (magento#2792) * Updated FormattedMessage component mock. * div -> mock-FormattedMessage * div -> mock-FormattedMessage * Resetting price mock. * Price component snap rollback. * - Adjust item grid based on UX feedback - Add context for providing product url suffix that is missing from graphql response * Fixup failing tests * Address PR feedback * Cover new context with tests * Address QA feedback * Fixup tests and hide incomplete features * Address additional edges found in QA * Dependently render discount row * Update snaps with new mock * Allow empty string as quantity value to support backspace Co-authored-by: Revanth Kumar Annavarapu <35203638+revanth0212@users.noreply.github.com> * fix: Service Worker caching for home page routes w/ store code (magento#2856) * Fix regex for html file type. Previous regex matched incorrect * Use available store views in SW home route check Signed-off-by: sirugh <rugh@adobe.com> * Update tests Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * issue-2743-function-retreiveAvailableShippingMethods-spelling-change- changed the function name in both the occurences (magento#2807) Co-authored-by: Stephen <sirugh@users.noreply.github.com> * Update index.md (magento#2865) Co-authored-by: Stephen <sirugh@users.noreply.github.com> * [docs]: Add info about RAIL model (magento#2761) * Update index.md * Update pwa-devdocs/src/technologies/overview/index.md Co-authored-by: Stephen <sirugh@users.noreply.github.com> Co-authored-by: Stephen <sirugh@users.noreply.github.com> Co-authored-by: James Calcaben <jcalcaben@users.noreply.github.com> * [Doc] extensibility framework overview (magento#2863) * Add TOC entry * Add new topic file and outline * Add how it works section * Add interceptor pattern section and image * Add content for Targets section * Add content for Intercept files * Finish Declare file content * Add content for Targets in PWA Studio packages * Add list of extension examples * Add extensibility overview diagram * Apply suggestions from code review Co-authored-by: Andy Terranova <13182778+supernova-at@users.noreply.github.com> * Fix links * Fix linting issues * Add example intercept file content Co-authored-by: Andy Terranova <13182778+supernova-at@users.noreply.github.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * [feature]: Display "no payment method available" message if no allowed or configured payment methods are present (magento#2855) * Filtered payment method radios. Filtered payment method radios array because it was coming like [undefined, undefined] * Showing "No Payment method available." message Showing "No Payment method available." message when there are no supported payment methods available. * Created class to add padding to no payment method message Created class to add padding to no payment method message * Fixed formatting using prettier * Formatted with prettier * Fixed typo suggested by @sirugh * Added plain string to i18n * Added string to translations * Fixed Typo * Fixed typo * Update packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/paymentMethods.js Co-authored-by: Stephen <sirugh@users.noreply.github.com> * Update packages/venia-ui/i18n/en_US.json Co-authored-by: Stephen <sirugh@users.noreply.github.com> * Fixed suggested changes given by sirugh * Added missing dep react-intl * Updated error messages and added global error color to it. * Added error test. Co-authored-by: Stephen <sirugh@users.noreply.github.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> Co-authored-by: Revanth Kumar <revanth0212@gmail.com> * [PWA-633] My Account: Address Book: Main View (magento#2857) * Stub out address card functionality based on new mocks * - Address some missed AC and hide dead links - Cover changes in tests * Update snaps and cleanup * - Sort addresses so default comes first - Add full page loading indicator on cold cache render - Add phone number - Add full country name display * Use country data from backend until DisplayNames is more widely supported Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Move product detail GraphQl fields to fragment (magento#2868) * move product detail graphql fields to fragment * move gql from venia-ui to peregrine * update test case * Use ApolloClient for MagentoRoute (magento#2859) * Use Apollo for MagentoRoute * Move queries to the talon * Adjust category page loading * Refactor to avoid repeat calls * Fixup * Remove getRouteComponent * Start tests * Rewrite unit tests * Lift state up to context * @brendanfalkowski * Remove old query * Inline response objects * Update snapshots * Update category snapshots Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Fix apiBase URL in resolveUnknownRoute.js (magento#2877) * Fix apiBase URL in resolveUnknownRoute.js Fix URL used by `resolveUnknownRoute.js` so it takes `apiBase` into account when constructing URL to GraphQL server * Add test for store base Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Use async version of act() (magento#2880) * Added feature to pick from multiple sample backends. (magento#2853) * Initial work * Added magento backend validation. * Updated intercept to fetch backends. * Fetching sample backends while creating a pwa app. * Minor. * Added try catches. * Updated docs. * Minor. * Added node-fetch peer dep. * Minor pretty print stuff. * Added lodash and node-fetch deps. * Updated extension desc. * Updated tests. * Minor. * Updated remaining tests. * Added runEnvValidators.js tests. * Fixed linter issues. * Minor. * Added intercept tests. * Using debug instead of console.error. * Moving backend related code to run after configureWebpack. * Updated the skipped test. * Update ENV error reporting message. * Minor. * Minor. * Updated error snapshot test. * Minor. * Minor. * Added or condition for path variable in tests. * Minor. * Updated tests to use snapshots. * Mock everything, lets get this working. * Removed unecessary mocks. * Updated tests. * Using try catch to avoid prj creations. * Reporting different message if otherBackends is empty. * Updated tests. * Prettier fix. * Added console warning for production deployment. * Updated production launch checklist docs. Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * [PWA-1128] fix(buildpack): Stop apicache from overriding good cache headers. (magento#2870) * fix(buildpack): Stop apicache from overriding good cache headers. Fixes PWA-1128. * fix(venia-ui): add cache headers to upward.yml staticFromRoot resolver * fix: add simple max-age behavior to upward DirectoryResolver Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * magento/magento2-page-builder/magento#637: Form field/field group viewport scope (magento#2881) - collect only desktop styles Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * [doc] update cloud deployment topic (magento#2871) * Add new sections in the beginning * Revise steps and adding required extensions step * Add section about setting environment variables * Remove optional and unneeded steps * Add build, commit, and deploy sections * Add more details on finding the correct UPWARD path value * Update based on feedback * Minor content update * Changes based on review feedback * Clarify env variables section * Minor fixes Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Handle array of paths as route pattern (magento#2893) * Handle array of paths as route pattern * JSON.parse route pattern when applying to Route path prop * Add tests to makeRoutesTarget * Fix missing projectConfig in create-custom-origin (magento#2897) * Fix missing projectConfig in create-custom-origin * Update examples in docs Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Improve RootComponents talons test coverage (magento#2896) * Refactor useCategory tests * Refactor useCategory test file * Add test to useCategory.spec.js * Add location search filter test to useCategory.spec.js * Add test for error on useCategory.spec.js * Finish test coverage for useCategory * Write tests for useNoProductsFound() talon * Add tests for useCategoryContent() talon Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Address Book - Add & Edit (magento#2879) * Initial layout of add / edit form * Adds unit tests * Adding address full flow. Stubs out edit address. * Country field to use country_code * Properly formats FormErrors * Absolute imports * Seeds and sets the form properly * Implements edit flow end to end * Disable dialog buttons while saving * Updates unit tests and snapshots * Implements default address checkbox * Smoothing out edges around default addresses * Attempt to fix broken test * Determinant sorting for default addresses * Update packages/venia-ui/lib/components/AddressBookPage/addressBookPage.js Co-authored-by: Jimmy Sanford <jimbo@users.noreply.github.com> * Remove auto-defaulting of addresses * Remove query result fields from add mutation * Adds query result fields to upadte mutation * Adds AddEditDialog classes to propTypes * Simplify passing parameter to edit callback function * Adds address fragments * Wait for refetchQueries to complete before finishing mutation * Waits for refetchQueries before closing dialog. Renames props. * Updates unit tests based on prop rename * Binds edit address function at creation time * Updates unit tests * Adds middle name to AddressCard display * Dialog to properly unmount on hide * Updates unit tests * Fixes new address bug * Simplifies seeding the form in useAddressBookPage talon * Adds JSDocs Co-authored-by: Jimmy Sanford <jimbo@users.noreply.github.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * [feature] Use root category id from gql (magento#2902) * Use storeConfig query to obtain root category id instead of hardcoding. * Update tests * Lint Signed-off-by: sirugh <rugh@adobe.com> * Set the root category once it resolves Signed-off-by: sirugh <rugh@adobe.com> * prettier Signed-off-by: sirugh <rugh@adobe.com> * Query for root category id for fallback on cms * Protect against null id * fix tests Signed-off-by: sirugh <rugh@adobe.com> * Use id in storeConfig query Signed-off-by: sirugh <rugh@adobe.com> * magento#2797. Re-factor Edit Product to use Dialog (magento#2824) * Re-factor Edit Product to use Dialog (magento#2797) * Re-factor Edit Product to use Dialog - CR fixes * Fixed QTY update on cart editing Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * [PWA-458] Checkout - Sign In View (magento#2889) * Remove sign-in link from CartPage * Apply new style and positioning to sign in container * - Implement view switcher similar to how the account menu works - Tweak some styles in mobile view * - Order imports consistently - Add/remove changes to language file * - Reset view state when you return to checkout - Add heading to Create Account form - Made cancel buttons low priority per UX guidance - Fixed button layout of Create Account form so it uses rows on mobile - Move SignIn container above Guest Checkout header on mobile * Update existing tests * Cover new component with tests * Add propTypes to new component * Make callback optional and remove noop function prop Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Allow self signed certs for backend validation and only attach to scaffold sample (magento#2891) * Allow self signed certs for backend validation Signed-off-by: sirugh <rugh@adobe.com> * remove log Signed-off-by: sirugh <rugh@adobe.com> * Only copy the extension to scaffolded apps Signed-off-by: sirugh <rugh@adobe.com> * Only include sample backend validator if scaffold selection is sample Signed-off-by: sirugh <rugh@adobe.com> * Add lodash as dependency to venia-concept Signed-off-by: sirugh <rugh@adobe.com> * update lockfile Signed-off-by: sirugh <rugh@adobe.com> * Make createProjectFromVenia async Signed-off-by: sirugh <rugh@adobe.com> * Update test Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Wait to render confirmation until details return (magento#2850) * Add Adobe client data layer (magento#2852) * Add Adobe client data layer * Clean up * Update package description Co-authored-by: deloreyj <deloreyjmi@gmail.com> * Move definition to the effect * Don't parse acdl minified code * Include react as peerDep * Bump peregrine peerdep to a caret * Revert eb59d1c Revert to tilde. Release script doesn't handle carets well, and this isn't significant. Co-authored-by: deloreyj <deloreyjmi@gmail.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> Co-authored-by: Dev Patil <depatil@adobe.com> * Saved payment methods main view. (magento#2882) * Enabled saved payments link. * Added payment skeleton. * Moved stuff around. * Snapshot update. * Added other card types. * Cleaned up some css. * Using INTL. * Minor. * Minor css change. * Changed name of payments target to checkoutPagePaymentTypes. * Added savedPaymentTypes target. * Updated target docs. * Minor. * Hide delete text in mobile view. * Address PR feedback * Snapshot updates. * Updated snapshots. * Updated tests. * Added new tests. * Minor * Hiding delete button till PWA-638 comes in. * Added new tests. * Minor. * Rendering no payments message. * Clear CustomerPaymentTokens on signout. * Rendering fullpageindicator when data is loading. * Snapshot update. * Removing unnecessary piece of code. Co-authored-by: Tommy Wiebell <twiebell@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * [Doc] Refactor tutorials section (magento#2907) * Archive css modules topic in tutorials * Archived Using Component Props topic * Archive Manage State topic * Archive Work with GraphQL topic * Remove links to archived pages in overview topic * Archive Hello UPWARD tutorials * Various updates * Add Next Steps to project structure Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Add props to nav query to render root category links (magento#2911) Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Relative import for local custom loader (magento#2912) Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Delete Address from Address Book (magento#2888) * Initial delete implementation * * Binds delete function * Waits to dismiss overlay * Cancel button is low priority styled * * Stabilizes sorting * Consistent spacing between confirm buttons * Updates unit tests and snapshots * Fixes confirmation button spacing for mobile * Remove max-width on confirmation buttons * Responsive delete confirm buttons * Updates unit tests to include new output properties * Address UX feedback * Added addressCard tests. * Added addressBookPage tests. Co-authored-by: Revanth Kumar <revanth0212@gmail.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Hide links (magento#2918) * v9.0.0-alpha.1 * v9.0.0-alpha.2 * Order History Page Search (magento#2916) * Initial work. * Lil better with loading states. * Using debounce to fetch order number. * Re arranging useEffects. * Updated CSS. * Order search useEffect logic change. * Using onCompleted instead. * Final touchups. * Minor. * Addressed UX review. * Using submit button to search for orders. * Minor. * Minor. * Added orderHistoryPage tests. * Using fragments. * Using fuzzy search. * Added useOrderHistory tests. * Using single query for order and orders data. * Fetch all orders if search text is empty. * Allowing button submit even if the search field is empty to fetch all orders. * Test update. * [PWA-887] My Account: Order History - Pagination (magento#2928) * Working PoC of moving form context to just wrap search inputs * Add simple pagination logic * - Fix rendering of reset button - Add Load More button and wire up to orders query * Increase page size to UX requirement and remove unnecessary currentPage argument * Add page info label to top of page * Cover changes with tests * - Use token for font size - Make callback optional and document * [fix] offline cached search and category pages (magento#2929) * Moves getPageSize query to talon default operation Signed-off-by: sirugh <rugh@adobe.com> * Only show search page error if there is no data. Signed-off-by: sirugh <rugh@adobe.com> * Only render errors when error AND no data Signed-off-by: sirugh <rugh@adobe.com> * Update tests Signed-off-by: sirugh <rugh@adobe.com> * Make sure we only do the page reset if there is no data Signed-off-by: sirugh <rugh@adobe.com> * Test page setting effect Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * v9.0.0-beta.1 * [doc] release notes 9.0.0 (magento#2935) * Clear out old 8.0.0 content * Add link references * Add page 1 PR entries * Add page 2 entries * Add page 3 entries * Add page 4 and 5 entries * Add details to highlights * Update compatibility table * Update highlight and known issue * Update Top Community Contributors * Update content based on feedback * Fix capitalization * Add missing entries Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Bump hastily dependency (magento#2963) * v9.0.0-beta.2 * v9.0.0-rc.1 * Add known issue about watcher running out of memory (magento#2977) * Add known issue about watcher running out of memory * Add link * Update note about watcher duration * v9.0.0 * Remove lodash from create-pwa * Fix bug * Extend fix to venia-concept * Using map instead of set. Co-authored-by: Tommy Wiebell <twiebell@adobe.com> Co-authored-by: Stephen <sirugh@users.noreply.github.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> Co-authored-by: Sathiya Prakash <50226394+sathiyaaa@users.noreply.github.com> Co-authored-by: Hiren Patel <hirenpatelmail@gmail.com> Co-authored-by: Abrar Pathan <abrarkhan@krishtechnolabs.com> Co-authored-by: James Calcaben <jcalcaben@users.noreply.github.com> Co-authored-by: Andy Terranova <13182778+supernova-at@users.noreply.github.com> Co-authored-by: Ankur Raiyani <ankurvr7003@gmail.com> Co-authored-by: Huy Kon <huykon225@gmail.com> Co-authored-by: Jimmy Sanford <jimbo@users.noreply.github.com> Co-authored-by: Sergey Kolodyazhnyy <sergey.kolodyazhnyy@gmail.com> Co-authored-by: sirugh <rugh@adobe.com> Co-authored-by: James Zetlen <jzetlen@adobe.com> Co-authored-by: Oleksandr Miroshnichenko <miroshni@adobe.com> Co-authored-by: Papilion Dániel <papiliond.94@gmail.com> Co-authored-by: Kristof, Fooman <kristof@fooman.co.nz> Co-authored-by: Marcin Kwiatkowski <contact@frodigo.com> Co-authored-by: deloreyj <deloreyjmi@gmail.com> Co-authored-by: Dev Patil <depatil@adobe.com> Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>

ankurvr added 3 commits November 10, 2020 16:34

Filtered payment method radios.

08817ba

Filtered payment method radios array because it was coming like [undefined, undefined]

Showing "No Payment method available." message

d60d2de

Showing "No Payment method available." message when there are no supported payment methods available.

Created class to add padding to no payment method message

dc36148

Created class to add padding to no payment method message

m2-community-project bot added the Progress: ready for review label Nov 10, 2020

PWAStudioBot added the pkg:venia-ui label Nov 10, 2020

ankurvr changed the title ~~Ankurvr payment method~~ It's not showing any message when there are no supported payment methods available Nov 10, 2020

ankurvr added 2 commits November 10, 2020 17:13

Fixed formatting using prettier

aa58d53

Formatted with prettier

b36cf32

sirugh reviewed Nov 10, 2020

View reviewed changes

packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/paymentMethods.js Outdated Show resolved Hide resolved

m2-community-project bot assigned sirugh Nov 10, 2020

m2-community-project bot added Progress: review and removed Progress: ready for review labels Nov 10, 2020

Fixed typo suggested by @sirugh

8cce370

ankurvr commented Nov 11, 2020

View reviewed changes

packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/paymentMethods.js Outdated Show resolved Hide resolved

ankurvr added 4 commits November 11, 2020 11:16

Added plain string to i18n

3c72c4b

Added string to translations

80b711c

Fixed Typo

f5d9728

Fixed typo

dacd77a

ankurvr requested a review from sirugh November 11, 2020 09:04

sirugh changed the title ~~It's not showing any message when there are no supported payment methods available~~ [feature]: Display "no payment method available" message if no allowed or configured payment methods are present Nov 16, 2020

sirugh requested changes Nov 16, 2020

View reviewed changes

m2-community-project bot added Progress: changes requested and removed Progress: review labels Nov 16, 2020

Update packages/venia-ui/lib/components/CheckoutPage/PaymentInformati…

99e65e7

…on/paymentMethods.js Co-authored-by: Stephen <sirugh@users.noreply.github.com>

m2-community-project bot added Progress: approved and removed Progress: review labels Nov 17, 2020

Updated error messages and added global error color to it.

05ada85

ankurvr dismissed sirugh’s stale review via 05ada85 November 19, 2020 04:36

sirugh previously approved these changes Nov 19, 2020

View reviewed changes

Merge branch 'develop' into ankurvr-payment-method

2347b86

Added error test.

36613c5

revanth0212 dismissed sirugh’s stale review via 36613c5 November 23, 2020 17:48

supernova-at approved these changes Nov 23, 2020

View reviewed changes

m2-community-project bot assigned supernova-at Nov 23, 2020

dpatil-magento merged commit 38bbde0 into magento:develop Nov 23, 2020

m2-community-project bot added Progress: done and removed Progress: approved labels Nov 23, 2020

github-jira-sync-bot mentioned this pull request Jul 15, 2021

[feature]: Display page level error and disable checkout button when no available payment methods #2869

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature]: Display "no payment method available" message if no allowed or configured payment methods are present #2855

[feature]: Display "no payment method available" message if no allowed or configured payment methods are present #2855

ankurvr commented Nov 10, 2020 •

edited by sirugh

Loading

PWAStudioBot commented Nov 10, 2020 •

edited

Loading

ankurvr left a comment

sirugh commented Nov 16, 2020

ankurvr commented Nov 17, 2020

schensley commented Nov 17, 2020 •

edited

Loading

ankurvr commented Nov 18, 2020

schensley commented Nov 18, 2020

sirugh commented Nov 18, 2020

ankurvr commented Nov 19, 2020 •

edited

Loading

sirugh left a comment •

edited

Loading

sirugh commented Nov 19, 2020

schensley commented Nov 19, 2020 •

edited

Loading

ankurvr commented Nov 19, 2020

sirugh commented Nov 19, 2020

dpatil-magento commented Nov 19, 2020

[feature]: Display "no payment method available" message if no allowed or configured payment methods are present #2855

[feature]: Display "no payment method available" message if no allowed or configured payment methods are present #2855

Conversation

ankurvr commented Nov 10, 2020 • edited by sirugh Loading

Description

Related Issue

Acceptance

Verification Stakeholders

Specification

Verification Steps

Screenshots / Screen Captures (if appropriate)

Checklist

PWAStudioBot commented Nov 10, 2020 • edited Loading

ankurvr left a comment

Choose a reason for hiding this comment

sirugh commented Nov 16, 2020

ankurvr commented Nov 17, 2020

schensley commented Nov 17, 2020 • edited Loading

ankurvr commented Nov 18, 2020

schensley commented Nov 18, 2020

sirugh commented Nov 18, 2020

ankurvr commented Nov 19, 2020 • edited Loading

sirugh left a comment • edited Loading

Choose a reason for hiding this comment

sirugh commented Nov 19, 2020

schensley commented Nov 19, 2020 • edited Loading

ankurvr commented Nov 19, 2020

sirugh commented Nov 19, 2020

dpatil-magento commented Nov 19, 2020

ankurvr commented Nov 10, 2020 •

edited by sirugh

Loading

PWAStudioBot commented Nov 10, 2020 •

edited

Loading

schensley commented Nov 17, 2020 •

edited

Loading

ankurvr commented Nov 19, 2020 •

edited

Loading

sirugh left a comment •

edited

Loading

schensley commented Nov 19, 2020 •

edited

Loading