Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: It's not showing any message when there are no supported payment methods available #2854

Closed
1 of 8 tasks
ankurvr opened this issue Nov 10, 2020 · 2 comments · Fixed by #2855
Closed
1 of 8 tasks
Assignees
Labels
bug Something isn't working Progress: done

Comments

@ankurvr
Copy link
Member

ankurvr commented Nov 10, 2020

Describe the bug
It's not showing message when there are no supported payment methods available.
It's becoming and empty container instead of showing proper message.

To reproduce
Steps to reproduce the behavior:

  1. Make sure you have braintree payment method disabled and other payment methods like Purchase order, bank transfer enabled.
  2. Add any product to cart
  3. Go to Cart -> Checkout
  4. Add shipping address and select any shipping method
  5. Let it load the payment methods from server. After loading completion payment method container will become empty as shown in below screenshot.

Expected behavior
It should show message like "No Payment method available.", but it's not showing anything and container becomes empty as shown in below screenshot.
Screen Shot 2020-11-10 at 4 42 19 PM

Screenshots
Screen Shot 2020-11-10 at 4 22 34 PM
Screen Shot 2020-11-10 at 4 22 59 PM

Additional context
Make sure you have braintree payment method disabled and other payment methods like Purchase order, bank transfer enabled.

Possible solutions
Adding message will do the job

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]:
  • OS [e.g. iOS8.1, Windows 10]:
  • Browser [e.g. Chrome, Safari]:
  • Browser Version [e.g. 22]:
  • Magento Version:
  • PWA Studio Version:
  • NPM version npm -v:
  • Node Version node -v:

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@ankurvr ankurvr added the bug Something isn't working label Nov 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 10, 2020

Hi @ankurvr. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@ankurvr
Copy link
Member Author

ankurvr commented Nov 10, 2020

@magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Progress: done
Projects
None yet
1 participant