[PWA-893] My Account: Order History - Remove @client directive

[tjwiebell]

Description

This feature is being included in PWA v8, and to support 2.4.0, it was developed with mock data and uses the @client directive so it doesn't hit the actual backend for data. Once all of our backing instances have been upgraded to 2.4.1, our support matrix for the next release (v9) will shift to 2.4.1-2.4.2, and this @client directive can safely be removed.

This should go smoothly, but a full round of QA will need to happen now that Devagouda Patil can test against live data.

Acceptance Criteria
@client directive removed
MOCK_ORDERS and CUSTOM_TYPES are removed, and useTypePolices call in useOrderHistoryPage is removed
Configurable product images should load with real data.

Related Issue

• [PWA-893] My Account: Order History - Remove @client directive

Acceptance

Verification Stakeholders

Specification

Verification Steps

1. Login as Customer with Orders and go to Order History Page
2. Verify that everything continues rendering as it did before with mock data

Screenshots / Screen Captures (if appropriate)

Checklist

• I have added tests to cover my changes, if necessary.

• I have updated the documentation accordingly, if necessary.

[tjwiebell]

Had to change this over to query by URL Key, since the product_sku returned by orders was variant skus which will return no results from the backend. Issue was escalated to GraphQL team, and they will be adding new fields in 2.4.2 so we shouldn't need to make a secondary query to get this data.

[sirugh]

which will return no results from the backend.

Is this because of our sample data or is it by design of the API?

[tjwiebell]

That is by design; configurable variants all have Visibility = Not Visible Individually, so GraphQL is correct in not returning them. Couple JIRA tickets were created to address this though; this one so we don't even need to do a second query for images, and this one so parent sku is returned (which is also a blocker to doing re-orders).

[PWAStudioBot]

	Messages
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖	Associated JIRA tickets: PWA-893.

Generated by 🚫 dangerJS against a1a069b

[tjwiebell]

@magento import pr to magento-commerce/pwa-studio

[magento-engcom-team]

@tjwiebell the pull request successfully imported.

[schensley]

This looks good @tjwiebell . Thanks. UX Approved.

[dpatil-magento]

I have already updated about these findings to @tjwiebell , posting here just for reference -

1. Simple product qty/price field misplaced when compared to configurable products.
2. Bundle product thumbnail also shown with simple product when the simple product is part of bundle product.
3. Latest order displayed at bottom instead of Top.
4. Gift card row is missing in Order Total
5. Bug Again/Print Receipt links are dead, can we keep them or remove?
6. Tracking number is not a link and needs some updates around upper/lower cases.
7. john.doe@example.com/ 123123^q has error toast on mcstaging backend.
8. Order with 5 products display +1 instead of showing the 5th order in place of +1.
9. Street 1 and 2 don't have spacing.
10. If a order has multiple shipping packages then only first shipping info is displayed.

[tjwiebell]

Simple product qty/price field misplaced when compared to configurable products.
Order with 5 products display +1 instead of showing the 5th order in place of +1.

Initially reviewed with UX, @schensley approved. Might be worth double checking if we'd like to move config options to the third column to keep things in consistent columns, but not a blocker.

Bundle product thumbnail also shown with simple product when the simple product is part of bundle product.
Bug Again/Print Receipt links are dead, can we keep them or remove?
Street 1 and 2 don't have spacing.
If a order has multiple shipping packages then only first shipping info is displayed.

Fixed in 1c1a478

Latest order displayed at bottom instead of Top.
Gift card row is missing in Order Total

Created MC-38927 and MC-38928; neither were possible with existing coverage.

Tracking number is not a link and needs some updates around upper/lower cases.

Left as plain strings and fixed up label to adhere to suggestion from UX in JIRA comment about expected rendering. We can address linkage in the ticket you created about the Luma view that we've broken for tracking shipments.

john.doe@example.com/ 123123^q has error toast on mcstaging backend.

Somehow there is an order without a shipping address on this account. Since this is something we do not support currently, I think we can ignore.

[fooman]

@tjwiebell what would a solution to fix the order with no shipping address look like? This is something we will need rather soon (I'd imagine PWA Studio for Commerce too as otherwise one couldn't for example order just a virtual gift card).

[sirugh]

what would a solution to fix the order with no shipping address look like?

We have an upcoming epic to work on additional product types and I imagine that work would get handled there or sooner. To start, I'm curious if the UI has any way to "know" that there won't be a shipping address. It's not like we query for "required checkout steps" and I'm not sure there's even an API for that. Might have to do some UI logic and check if all items are virtual/don't need shipping.

[dpatil-magento]

@tjwiebell Some more observations -
10 (continued). Multiple Shipment info is displayed correctly now but single shipment with multiple packages only first package tracking is displayed, order ending in 575 is below screen

11. Discount row is displayed always, expected? I was hoping to see only when order has discount applied.
12. Only first 20 orders are returned by Graphql even when more orders are available.
13. When an order is placed making it as an out of stock product, on accessing order history TypeError: Cannot read property ‘url’ of undefined

[tjwiebell]

@tjwiebell what would a solution to fix the order with no shipping address look like? This is something we will need rather soon (I'd imagine PWA Studio for Commerce too as otherwise one couldn't for example order just a virtual gift card).

This is a fair point, and a solution so simple we might as well handle now. While it has grown quite large, the intention here wasn't to mess with the existing implementation of components, but given some changes were necessary with live data, I can take on this scope. A bigger point to address is that we're all following our schemas correctly; myself included, I expect data even though non-required fields are nullable, and our designs and implementations don't account for this.

[tjwiebell]

@dpatil-magento

• Fixed 10, 13, and null shipping address in 5604e84. Just used a placeholder label for null shipping until the Virtual Product epic addresses the rest.
• 11 has been UX approved, leaving for now.
• 12 is expected, we have a Story to add pagination and search to this view

[dpatil-magento]

Thanks @tjwiebell almost there, some minor ones -
13 (continued) - Its fixed, but Thumbnail image is missing, expected?
14 - Localization - When Discount price is 0 then it has $ sign instead of Euro.

15 - On switching store, previous store data is shown and then data is updated for new store.

[tjwiebell]

@dpatil-magento

13. Missing thumbnail is expected given we have to do a second query to get images. Since the item is now OOS, GraphQL won't return any data about it anymore. There are fixes landing in 2.4.2 to will remove the need for this second query, and this should resolve itself.

14. Tripled checked with UX, decided to dependently render this row like you suggested. Fixed in b8eb620.

15. I'm not gonna get near store code switching and cache invalidation, but we can create a bug for the Owls to see if this is something that needs addressed. I would expect this view not to care about store and render orders placed on both stores anyway, since carts/orders are shared across website scope.

[sirugh]

I'm not gonna get near store code switching and cache invalidation, but we can create a bug for the Owls to see if this is something that needs addressed. I would expect this view not to care about store and render orders placed on both stores anyway, since carts/orders are shared across website scope.

You're seeing stale data because we render from cache. Once the store code is changed using the switcher, we refresh the page and re-query with the new store code in the appropriate header. After refresh, but before the new query returns, you will see cached data. That's just how it works with any query on reload when configured to use cache-and-network.

[dpatil-magento]

QA Approved.