-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: price filter incorrectly fetches/displays #3161
Comments
Hi @sirugh. Thank you for your report. Please, add a comment to assign the issue:
|
@magento export issue to JIRA project PWA as Bug |
✅ Jira issue https://jira.corp.magento.com/browse/PWA-1711 is successfully created for this GitHub issue. |
@sirugh this should only 1 selected of that, right? |
I'm not sure if these are supposed to work like single select radios or multi select checkboxes. Two questions -
If we can answer those questions we will have a good idea of what we need to do here |
|
Ok I'll verify #1 and update this issue when I get back Tuesday :) |
Ok - I updated the description of this ticket. We still need to have our PM/UX evaluate this issue and provide guidance for desired solution. |
@magento I am working on this |
Able to reproduce the issue and hence the issue is confirmed |
@adobe export issue to JIRA project PWA as Bug |
✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3162 is successfully created for this GitHub issue. |
Describe the bug
In the event that a different price filter is applied after a price filter is already applied, the query will only be for the first price filter, not the combination of the two.
This behavior might be interpreted as a bug but is actually a mis-implementation of the UI for the price filter which only allows a "range" ie
{ "from": "0", "to": "100" }
.We have several options for "fixing" this, which I will detail below.
To reproduce
Steps to reproduce the behavior:
Expected behavior
Either:
0
toX
whereX
is the greatest value in the available price filters list (for example: $200, in this case)Screenshots
Possible solutions
We should investigate possible solutions of combining filters into a range, if they are sequential such as
0-100
and100-200
or if it is even possible to send more than one filter if they are not sequential, such as0-100
and200-300
.The text was updated successfully, but these errors were encountered: