Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: price filter incorrectly fetches/displays #3161

Closed
sirugh opened this issue May 6, 2021 · 12 comments
Closed

[bug]: price filter incorrectly fetches/displays #3161

sirugh opened this issue May 6, 2021 · 12 comments
Assignees

Comments

@sirugh
Copy link
Contributor

sirugh commented May 6, 2021

Describe the bug

In the event that a different price filter is applied after a price filter is already applied, the query will only be for the first price filter, not the combination of the two.

This behavior might be interpreted as a bug but is actually a mis-implementation of the UI for the price filter which only allows a "range" ie { "from": "0", "to": "100" }.

We have several options for "fixing" this, which I will detail below.

To reproduce

Steps to reproduce the behavior:

  1. Go to https://develop.pwa-venia.com/default/venia-bottoms/venia-pants.html
  2. Click Filters and select Price > 100-200 and "See Results"
  3. Click Filters and select Price > 0-100 and "See Results" (don't clear the previous filter)
  4. See that the products are still those for the 100-200 price filter. The network will also show that only the 100-200 filter is sent in the query.

Expected behavior

Either:

  • The price filter should use a single select "radio" instead of a checkbox or
  • The price filter should use a slider allowing values from 0 to X where X is the greatest value in the available price filters list (for example: $200, in this case)

Screenshots

Image from Gyazo

Possible solutions

We should investigate possible solutions of combining filters into a range, if they are sequential such as 0-100 and 100-200 or if it is even possible to send more than one filter if they are not sequential, such as 0-100 and 200-300.

@sirugh sirugh added the bug Something isn't working label May 6, 2021
@m2-assistant
Copy link

m2-assistant bot commented May 6, 2021

Hi @sirugh. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@sirugh
Copy link
Contributor Author

sirugh commented May 6, 2021

@magento export issue to JIRA project PWA as Bug

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/PWA-1711 is successfully created for this GitHub issue.

@huykon
Copy link
Contributor

huykon commented May 29, 2021

@sirugh this should only 1 selected of that, right?

@sirugh
Copy link
Contributor Author

sirugh commented May 29, 2021

I'm not sure if these are supposed to work like single select radios or multi select checkboxes. Two questions -

  • Is it possible to query gql with two or more price filters?
  • What does Luma do?

If we can answer those questions we will have a good idea of what we need to do here ☺️

@huykon
Copy link
Contributor

huykon commented May 31, 2021

  1. I think price filters must 1
  2. The Luma theme only support single select for this

@sirugh
Copy link
Contributor Author

sirugh commented May 31, 2021

Ok I'll verify #1 and update this issue when I get back Tuesday :)

@sirugh
Copy link
Contributor Author

sirugh commented Jun 1, 2021

Ok - I updated the description of this ticket. We still need to have our PM/UX evaluate this issue and provide guidance for desired solution.

@Sahilsks
Copy link
Contributor

Sahilsks commented Mar 1, 2023

@magento I am working on this

@glo80771
Copy link
Contributor

Able to reproduce the issue and hence the issue is confirmed

@glo42707
Copy link
Collaborator

@adobe export issue to JIRA project PWA as Bug

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3162 is successfully created for this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants