Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures when MAGENTO_BACKEND_DOMAIN does not have trailing slash #337

Closed
DrewML opened this issue Oct 8, 2018 · 2 comments
Closed

Failures when MAGENTO_BACKEND_DOMAIN does not have trailing slash #337

DrewML opened this issue Oct 8, 2018 · 2 comments
Assignees
@zetlen
Labels
help wanted Eligible for community contribution.

Comments

@DrewML
Copy link
Contributor

DrewML commented Oct 8, 2018

Currently, you get failures when MAGENTO_BACKEND_DOMAIN does not have a trailing / at the end. The name of the field has DOMAIN, which makes it surprising a / is required. The code should be updated to drop this requirement/bug.
@DrewML DrewML added the help wanted Eligible for community contribution. label Oct 8, 2018
@rowan-m
Copy link
Contributor

rowan-m commented Oct 8, 2018

This should be changed to MAGENTO_BACKEND_URL to more correctly describe what it is. Trailing slash should be optional. Path should be taken into account in case someone is running their back-end under a path.

@zetlen
Copy link
Contributor

zetlen commented Oct 8, 2018

All true. I'll update #339 to change this variable and print a warning.

@zetlen zetlen self-assigned this Oct 8, 2018
zetlen pushed a commit that referenced this issue Oct 9, 2018
fix: rename MAGENTO_BACKEND_DOMAIN to MAGENTO_BACKEND_URL
eb96392 
More accurately reflects the contents of the variable. Fixes #337.
@zetlen zetlen closed this as completed in 449c52c Oct 9, 2018
@sharkySharks sharkySharks mentioned this issue Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zetlen zetlen

Labels
help wanted Eligible for community contribution.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rowan-m @zetlen @DrewML