Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] AC-2788::Form fields have visual labels that are not programmatically… #3837

Closed
m2-assistant bot opened this issue May 4, 2022 · 2 comments · Fixed by #3786
Closed

[Issue] AC-2788::Form fields have visual labels that are not programmatically… #3837

m2-assistant bot opened this issue May 4, 2022 · 2 comments · Fixed by #3786

Comments

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2022

This issue is automatically created based on existing pull request: #3786: AC-2788::Form fields have visual labels that are not programmatically…


Description

Form fields have visual labels that are not programmatically associated with their inputs (pattern: Form field(s) lack accessible name)

Reproduction Steps
Locations (representative sample):

Global Header

  • Checkout - Confirmation / Create an Account
    Sign In
    Account - Order History
  1. With JAWS operating, press Tab to move through the fields identified.

Actual Behavior
There are form fields with visible labels that are not programmatically associated with the input; these inputs have no accessible name.

Examples include:

Module 01a - Global Header:
Search (visible text beneath the search input "Search for a product" is not a element and is not programmatically associated with the input)

Module 06c - Checkout - Confirmation / Create an Account
(Note - the following form fields refer to "Quick Checkout When You Return")
Visible elements lack for attributes to associate them with their inputs, including:
First Name
Last Name
Email
Password

Module 07 - Sign In:
Visible elements lack for attributes to associate them with their inputs, including:
Email
Password

Expected Behavior
Ensure all controls provide a descriptive accessible name. Ensure visible elements are correctly associated with their inputs using the for attribute.

Related Issue

Closes https://jira.corp.magento.com/browse/AC-2788.

Verification Steps

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.
@supernova-at
Copy link
Contributor

@magento export issue to JIRA project PWA as Story

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/PWA-2819 is successfully created for this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants