AC-2788::Form fields have visual labels that are not programmatically…

[glo71317]

Description

Form fields have visual labels that are not programmatically associated with their inputs (pattern: Form field(s) lack accessible name)

Reproduction Steps
Locations (representative sample):

Global Header

• Checkout - Confirmation / Create an Account
  Sign In
  Account - Order History

1. With JAWS operating, press Tab to move through the fields identified.

Actual Behavior
There are form fields with visible labels that are not programmatically associated with the input; these inputs have no accessible name.

Examples include:

Module 01a - Global Header:
Search (visible text beneath the search input "Search for a product" is not a element and is not programmatically associated with the input)

Module 06c - Checkout - Confirmation / Create an Account
(Note - the following form fields refer to "Quick Checkout When You Return")
Visible elements lack for attributes to associate them with their inputs, including:
First Name
Last Name
Email
Password

Module 07 - Sign In:
Visible elements lack for attributes to associate them with their inputs, including:
Email
Password

Expected Behavior
Ensure all controls provide a descriptive accessible name. Ensure visible elements are correctly associated with their inputs using the for attribute.

Related Issue

Closes https://jira.corp.magento.com/browse/AC-2788.

Verification Steps

Checklist

• I have added tests to cover my changes, if necessary.
• I have added translations for new strings, if necessary.
• I have updated the documentation accordingly, if necessary.

Resolved issues:

1. resolves [Issue] AC-2788::Form fields have visual labels that are not programmatically… #3837: AC-2788::Form fields have visual labels that are not programmatically…

[pwa-studio-bot]

	Messages
📖	Associated JIRA tickets: AC-2788.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 4a836a9

[glo71317]

run all tests

[supernova-at]

@magento create issue from PR

[dpatil-magento]

run pr-deploy

[pwa-test-bot]

Successfully started codebuild job for pr-deploy

The base branch was changed.

[dpatil-magento]

run cypress

[pwa-test-bot]

Successfully started codebuild job for cypress

[pwa-studio-bot]

	Fails
🚫	node failed.
🚫	Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged verify block content: Error: Image was 1.4374855388718188% different from saved snapshot with 92661.46782410853 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/__diff_output__/Page-Builder-Block-Page.diff.png

Log

ERROR ON TASK: cypressTests

Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 4a836a9

[pwa-studio-bot]

	Fails
🚫	node failed.
🚫	Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged user should be able to filter results in Category and Search pages: CypressError: The application redirected to `https://pr-3786.pwa-venia.com/search.html?query=Tops&page=1&price%5Bfilter%5D=100-200%2C100_200&category_uid%5Bfilter%5D=Tops%2C8` more than 20 times. Please check if it's an intended behavior. If so, increase redirectionLimit value in configuration.

Log

ERROR ON TASK: cypressTests

Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 4a836a9

[dpatil-magento]

QA Approved, cypress failures not related.