-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when getting thumbnails on order row for deleted products #4307
Comments
Hi @vacla. Thank you for your report. Join Magento Community Engineering Slack and ask your questions in #github channel. |
@adobe export issue to JIRA project PWA as Bug |
✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3359 is successfully created for this GitHub issue. |
Hi @vacla Thank you for bringing this up! Could you please clarify why you are deleting a product from the backend and checking the order history for deleted products ? we are curious if this is a specific case for any of your clients or if it has caused issues in one of your projects. Thanks. |
@del15881 We are removing them when they are no longer in the collection available. If the product wasn't available we would want to show the placeholder image what is currently not possible due to this bug as it will error at that moment. |
Describe the bug
When getting orders with deleted products, it gives an error here:
pwa-studio/packages/peregrine/lib/talons/OrderHistoryPage/orderRow.gql.js
Line 14 in a3faf3f
This is the error:
To reproduce
Steps to reproduce the behavior:
Expected behavior
No error
Possible solutions
Make this an optional string:
pwa-studio/packages/peregrine/lib/talons/OrderHistoryPage/orderRow.gql.js
Line 14 in a3faf3f
Debug Report
ℹ Inspecting Dependencies
Found 9 https://github.com/magento dependencies in yarn.lock
@magento/pwa-buildpack @ 11.4.3
@adobe/apollo-link-mutation-queue @ 1.0.2
@magento/babel-preset-peregrine @ 1.2.3
@magento/eslint-config @ 1.5.3
@magento/pagebuilder @ 8.2.1
@magento/peregrine @ 13.2.1
@magento/pwa-theme-venia @ 1.4.0
@magento/venia-adobe-data-layer @ 1.0.0
@magento/venia-ui @ 10.3.0
ℹ Inspecting Magento Backend
Not using sample backend.
Backend is UP!
ℹ Inspecting System
OS: #39 SMP PREEMPT_DYNAMIC Fri Jul 5 21:49:14 UTC 2024
Node Version: v16.20.2
NPM Version: 8.19.4
Please complete the following device information:
Please let us know what packages this bug is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
The text was updated successfully, but these errors were encountered: