Refactor the Page component and its children #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
DrewML
previously approved these changes
Jun 15, 2018
|
Nice! |
jimbo
force-pushed
the
jimbo/page-refactor
branch
from
c6ca108
to
760ee3e
Compare
DrewML
reviewed
Jun 19, 2018
| classes: PropTypes.shape({ | ||
| root: PropTypes.string | ||
| }), | ||
| openCart: PropTypes.func |
There was a problem hiding this comment.
This should be marked as isRequired since there aren't any safeguards in place. Prevents a refactoring hazard later on
There was a problem hiding this comment.
Cool. Updated that on all the triggers.
To accommodate drawers and other top-level elements, the page components needs to be refactored. Also, the introduction of the router broke the navigation, since it was being wired by the App component, which is now defunct. This commit uses a new global reducer, `app`, replacing the old `navigation` one. It will manage drawer and overlay state. The header and footer have been moved into the Main component. This will preempt some stacking context issues. A mask has been added to the app when a drawer is open. Further masking may be added in the future for a modal dialog component.
jimbo
force-pushed
the
jimbo/page-refactor
branch
from
760ee3e
to
f04cad1
Compare
DrewML
approved these changes
Jun 20, 2018
|
Wooohooooooooo |
fnhipster
pushed a commit
to PMET-public/pwa-studio
that referenced
this pull request
Apr 9, 2019
* fix: remove buggy sudo-prompt until fallback works. Fixes magento#35. - Added custom prompt for command-line sudo. * fix: make runAsRoot simpler, prompt mandatory
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
[x] New feature
[x] Enhancement/Optimization
[x] Refactor
[x] Bugfix
[ ] Test for existing code
[ ] Documentation
Summary
To accommodate drawers and other top-level elements, the page components needs to be refactored. Also, the introduction of the router broke the navigation, since it was being wired by the App component, which is now defunct.
Additional information
This commit uses a new global reducer,
app, replacing the oldnavigationone. It will manage drawer and overlay state.The Header and Footer components have been moved into the Main component. This will preempt some stacking context issues.
A mask has been added to the app when a drawer is open. Further masking may be added in the future for a modal dialog component.