Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/pwa-studio#: Contributing page. Fix link #1571

Merged
merged 3 commits into from
Aug 19, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Aug 16, 2019

Description

Regarding to #1557 a correct URL to "Code of Conduct" is

https://github.com/magento/pwa-studio/blob/develop/.github/CODE_OF_CONDUCT.md

Related Issue

Closes #ISSUE_NUMBER.

Verification Steps

  1. Go to the https://magento.github.io/pwa-studio/technologies/contribute page.
  2. Click on the "Code of Conduct" link

Actual result: you will be redirected to https://github.com/magento/pwa-studio/blob/master/.github/CODE_OF_CONDUCT.md

Expected result: you should be redirected to https://github.com/magento/pwa-studio/blob/develop/.github/CODE_OF_CONDUCT.md

Affected pages

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

Thank you!

@vercel
Copy link

vercel bot commented Aug 16, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://pwa-studio-git-fork-atwixfirster-technologies-wrong-link.mmansoor.now.sh

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Aug 16, 2019

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" in your PR.

🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against f7d5c0c

@atwixfirster
Copy link
Contributor Author

@jcalcaben , could you please add Partner: Atwix, partners-contribution labels to this pull request?

Many thanks

@atwixfirster
Copy link
Contributor Author

@dpatil-magento could you please add Partner: Atwix, partners-contribution labels to this PR?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants