Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PB] Row component #1753

Merged
merged 6 commits into from
Sep 25, 2019
Merged

[PB] Row component #1753

merged 6 commits into from
Sep 25, 2019

Conversation

davemacaulay
Copy link
Contributor

@davemacaulay davemacaulay commented Sep 23, 2019 •
edited
Loading

Description

Introduce Row component for Page Builder Row content type

Note: we've opted to import Jarallax as we are aiming for feature parity with Luma storefront for Page Builder. In future we will look at other React specific solutions to improve this experience.

Related Issue

https://jira.corp.magento.com/browse/PB-2

Performance Results

https://wiki.corp.magento.com/display/COREENG/Row

Verification Steps

  1. Check that each property for each content type appearance renders correctly on PWA Venia storefront in desktop and mobile.
  2. Compare Venia PWA rendering of content type with Luma to ensure the experience is the same or better for each property of each appearance in desktop and mobile.
  3. Check each supported browser and on mobile that is supported according to PWA documentation.
  4. Acceptable performance has been validated

dhaecker and others added 3 commits September 18, 2019 12:15
@dhaecker
PB-2: Row content type in Venia UI / PWA Studio
aae53ba 
- Adding 100% test coverage for Page Builder Row content type
@davemacaulay
PB-2: Row content type in Venia UI / PWA Studio
92a2b1f 
- Remove react-parallax
- Import Jarallax and configure
- Increase test coverage to 100% for row
@davemacaulay
Merge branch 'feature/page-builder' into PB-2
5334eec 
# Conflicts:
#	packages/venia-concept/package.json
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Sep 23, 2019 •
edited
Loading

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PB-2.

Generated by 🚫 dangerJS against e1262c6

@davemacaulay davemacaulay added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Sep 23, 2019
@davemacaulay davemacaulay merged commit f9bbf88 into magento:feature/page-builder Sep 25, 2019
@davemacaulay davemacaulay deleted the PB-2 branch June 1, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmooney2 danmooney2 danmooney2 approved these changes

Assignees
No one assigned
Labels
pkg:venia-concept pkg:venia-ui version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davemacaulay @PWAStudioBot @danmooney2 @dhaecker @eug123