Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PB] Master format parser for PWA Studio #1777

Merged
merged 7 commits into from
Sep 25, 2019
Merged

[PB] Master format parser for PWA Studio #1777

merged 7 commits into from
Sep 25, 2019

Conversation

davemacaulay
Copy link
Contributor

@davemacaulay davemacaulay commented Sep 25, 2019 •
edited
Loading

Description

Improve automation and refactor around Page Builder parser

Related Issue

https://jira.corp.magento.com/browse/PB-4

Verification Steps

  1. Verify 100% automation coverage on associated components

dhaecker and others added 5 commits September 18, 2019 13:36
@dhaecker
PB-4: Master format parser for PWA Studio
cbbb7af 
- Adding some missing test coverage for PageBuilder/parseStorageHtml.js
- Adding 100% test coverage for PageBuilder/utils.js
@dhaecker
PB-4: Master format parser for PWA Studio
c7011ad 
- Adding snapshots for PageBuilder/parseStorageHtml.spec.js & PageBuilder/utils.spec.js
@davemacaulay
PB-4: Master format parser for PWA Studio
ecae35f 
- Improve test coverage
@davemacaulay
PB-4: Master format parser for PWA Studio
4dabfc7 
- Include documentation for parser and adding a new content type
@davemacaulay
Merge branch 'feature/page-builder' into PB-4
4598358
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Sep 25, 2019 •
edited
Loading

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PB-4.

Generated by 🚫 dangerJS against 5d12808

@davemacaulay davemacaulay added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Sep 25, 2019
@davemacaulay davemacaulay merged commit 9e2c880 into magento:feature/page-builder Sep 25, 2019
@davemacaulay davemacaulay deleted the PB-4 branch June 1, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmooney2 danmooney2 danmooney2 approved these changes

Assignees
No one assigned
Labels
pkg:venia-ui version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davemacaulay @PWAStudioBot @danmooney2 @dhaecker