Default pragma #229
Default pragma #229
Conversation
Generated by 🚫 dangerJS |
|
Updated, but the eslint fails are from the incorrect magento-eslint package. |
- Switched import { Component, createElement } from 'react';) to import React from 'react', { Component };
- Switched import { Fragment, createElement } from 'react';) to import React from 'react', { Fragment };
- Switched import { createElement } from 'react';) to import React from 'react';
- Added `eslint-plugin-react` and updated eslint configuration
accordingly
Update eslintrc and remove react imports from components which have no jsx
Add Component import back to ContainerChild.js
chore: Update .babelrc and rm redundant files
Switch to correct React import
prettify! ❤️
chore: update eslint-config with pcvonz fisx
zetlen
force-pushed
the
default-pragma
branch
from
dc6dd93 to
54930b1
Compare
There was a problem hiding this comment.
Looks good to me. Let's get this merged before too many other things go in.
@pcvonz Thanks for doing the legwork! I've merged the release branch into this and updated the components that didn't exist at the time you submitted this PR.
This PR is a:
[ ] New feature
[ ] Enhancement/Optimization
[x] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation
Summary
Switch back to the default pragma in our Babel configuration. More information on why this switch was made originally and why we're moving back are documented here
To sum it up though: We need to add something to our compiler to let it know how to compile JSX. A decision was made to stray away from the standard way. This pull request undoes that and implements the standard way. (Hope that sums it up well)
NOTE: This pull request is tied to this another pull request in
magento-eslint:magento/magento-eslint#1
Additional information
Fixes #21