Checkout selectors (Issues #241 and #242) #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Move selector component to the venia project from peregrine -Add properties paymentMethod and availablePaymentMethods to redux store -Grab availablePaymentMethods from Magento REST API -Wire selector component to checkout form
Add functionality to Get By section
…gson/pwa-studio into checkout-selectors
…gson/pwa-studio into checkout-selectors
Remove explicit name checking from the Selector component
…gson/pwa-studio into checkout-selectors
Merged
supernova-at
added a commit
to supernova-at/pwa-studio
that referenced
this pull request
Nov 28, 2018
|
Closed in favor of #556. @pcvonz @Serunde Thanks for all your work on this feature! Your commits were preserved in #556; @supernova-at added his own work on top of them and resolved conflicts with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
[x] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation
Summary
When this pull request is merged, it will
Address Shipping methods for Venia #241 and Payment methods for Venia (Check and Money Order) #242
Let a shopper choose a shipping method and payment method pulled from Magento's REST API
Add a generic component
Selector, that rendersSectionsthe user can choose fromMoves
subtotalto shared componentAdditional info
getters