-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer can style content types output differently per viewport #2694
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
43ede9d
magento/magento2-page-builder#558: Developer can style content types …
omiroshnichenko 6e295a7
magento/magento2-page-builder#558: Developer can style content types …
omiroshnichenko a3e9164
Merge branch 'develop' into PB-558
omiroshnichenko 0fde0ae
Merge branch 'develop' into PB-558
omiroshnichenko 48edd28
Merge branch 'develop' into PB-558
omiroshnichenko 9458cc4
Merge branch 'develop' into PB-558
dpatil-magento File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,6 +74,48 @@ const walk = (rootEl, contentTypeStructureObj) => { | |
return contentTypeStructureObj; | ||
}; | ||
|
||
const pbStyleAttribute = 'data-pb-style'; | ||
const bodyId = 'html-body'; | ||
|
||
/** | ||
* Convert styles block to inline styles. | ||
* @param {HTMLDocument} document | ||
*/ | ||
const convertToInlineStyles = document => { | ||
const styleBlocks = document.getElementsByTagName('style'); | ||
const styles = {}; | ||
|
||
if (styleBlocks.length > 0) { | ||
Array.from(styleBlocks).forEach(styleBlock => { | ||
const cssRules = styleBlock.sheet.cssRules; | ||
|
||
Array.from(cssRules).forEach(rule => { | ||
const selectors = rule.selectorText | ||
.split(',') | ||
.map(selector => selector.trim()); | ||
selectors.forEach(selector => { | ||
if (!styles[selector]) { | ||
styles[selector] = []; | ||
} | ||
styles[selector].push(rule.style); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Readability: New line after |
||
}); | ||
}); | ||
}); | ||
} | ||
|
||
Object.keys(styles).map(selector => { | ||
const element = document.querySelector(selector); | ||
|
||
styles[selector].map(style => { | ||
element.setAttribute( | ||
'style', | ||
element.style.cssText + style.cssText | ||
); | ||
}); | ||
element.removeAttribute(pbStyleAttribute); | ||
}); | ||
}; | ||
|
||
/** | ||
* Parse the master format storage HTML | ||
* | ||
|
@@ -85,6 +127,9 @@ const parseStorageHtml = htmlStr => { | |
|
||
const stageContentType = createContentTypeObject('root-container'); | ||
|
||
container.body.id = bodyId; | ||
convertToInlineStyles(container); | ||
|
||
return walk(container.body, stageContentType); | ||
}; | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readability: New line after
const
and/or beforeforEach
loop.