Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement basic login for Venia (Issue #249) #281

Closed
wants to merge 23 commits into from
Closed

Implement basic login for Venia (Issue #249) #281

wants to merge 23 commits into from

Conversation

JStein92
Copy link
Contributor

This PR is a:

[x ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation

Summary

When this pull request is merged, it will allow basic login using existing user accounts via REST API.

Addresses #249

login_real

Additional information

  • signin_token is retrieved from Magento REST API and is stored it local storage. If signin_token is present in local storage, it is added to all GraphQL and REST requests headers.

  • Adds a generic Input component, which lets developers customize error, success, and hint messages and the conditional which will display each one. This allows real time form validation, like ensuring a password is x characters, etc.

  • Adds Account drawer which is built into navigation.

  • Adds new actions and reducers for user functionality, (ex. SIGN_IN and SIGN_IN_ERROR)

  • Adds storybook-dist to eslint ignore

JStein92 and others added 23 commits September 7, 2018 07:28
@JStein92
create generic input component
174ddd0
@JStein92
ignore storybook-dist in eslint
25dcc9d
@JStein92
create login component, action and reducer catch
ac482dc
@pcvonz
Hook login form to utilize and store token
3ef5bb1
@pcvonz
Add navigation animation and user icon
2d9e7f7
@JStein92
add auth to REST requests
3561f71
@JStein92
Merge branch 'login' of https://github.com/bargreenellingson/pwa-studio…
9e3ab0c 
… into login
@pcvonz
Add user icon
5673948
@JStein92
Merge branch 'login' of https://github.com/bargreenellingson/pwa-studio…
614bd1d 
… into login
@JStein92
add auth header login_token to graphql queries
2b0d825
@pcvonz
Change animation, add user to store
455b7d3
@pcvonz
Move user logic into separate action/reducer
ece2eec
@pcvonz
Add token to auth headers when token is available (rest)
9ad855d
@pcvonz
Style sign in form, fix user reducer
ec87f4f 
- Style form to match mockup
- Fix misimport of user reducer
@pcvonz
Rename log in -> sign in. Wire up sign in form.
03bea9b 
- Rename log in to sign in to match mockups
- Style error messages in sign in form
@pcvonz
Change login to signin
491dfdc
@pcvonz
Add proptypes, clean up css
f109d81
@pcvonz
Prettier pass
293c523
@JStein92
write test for signIn and input, small style and prop fixes
fcfe28e
@JStein92
Merge branch 'master' into login
aa88455
@JStein92
lint and prettier pass
4fc83b7
@JStein92
reword a c ouple tests
28a8e51
@JStein92
fix dependency issue and clean up navigation component
240fc98
@JStein92 JStein92 mentioned this pull request Sep 20, 2018
Merged
@zetlen zetlen changed the base branch from master to release/1.0 September 25, 2018 20:42
zetlen
zetlen reviewed Sep 26, 2018
View reviewed changes
Copy link
Contributor

@zetlen zetlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, this is a subset of the changes in #250. If so, then can you please merge any updates you make to #250 into this? Once they're both ready to go, I'll merge them separately so that the history reflects each individual feature.

@zetlen zetlen changed the base branch from release/1.0 to release/2.0 September 26, 2018 21:05
@zetlen zetlen added the enhancement New feature or request label Sep 27, 2018
@zetlen
Copy link
Contributor

zetlen commented Oct 3, 2018

Hey @JStein92, what's the status of this issue now that #250 is merged?

@pcvonz
Copy link
Contributor

pcvonz commented Oct 18, 2018

@zetlen Looks like #293 included all commits from this pull request. This one can be closed.

@zetlen zetlen closed this Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetlen zetlen zetlen left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JStein92 @zetlen @pcvonz