Check if captureStackTrace exists before calling #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 994
💛 - Coveralls |
|
Hey @pcvonz, thanks for catching this. Would you mind adding a test for it, so we don't lose coverage? It would look something like this, in test('does not call Error.captureStackTrace if unavailable', () => {
const capture = Error.captureStackTrace;
Error.captureStackTrace = null;
// make sure you can still create an M2ApiResponseError without throwing
Error.captureStackTrace = capture;
}); |
Generated by 🚫 dangerJS |
zetlen
approved these changes
Sep 26, 2018
zetlen
added a commit
that referenced
this pull request
Sep 27, 2018
* Check if captureStackTrace exists before calling (#288) * Check if captureStackTrace exists before calling * Add test to ensure captureStackTrace isn't called when it does not exist * Prettier ✨ * Fix failing test (#304) Unit tests should use MemoryRouter, not BrowserRouter, and do shallow rendering rather than full mounting. * feat(dev): Make PWADevServer host/SSL optional (#175) PWADevServer attempts to create a unique domain name, create local SSL certificates, and tell the OS to trust those certificates, for every new project. It also tries to confirm they exist on every run! This causes many problems for users under some common conditions: - No administrative access to local machine - No OpenSSL installed, or wrong OpenSSL installed - OS cannot be scripted to trust certificates - Developer uses Firefox, which uses its own cert store Additionally, some bugs in the implementation have caused some developers' projects to enter an unusable state. - Adds `provideUniqueHost` flag to PWADevServer configuration. PWADevServer will no longer try to create or retrieve a custom domain name unless `provideUniqueHost` is in its configuration in `webpack.config.js` as either a custom string or `true`. - Adds `provideSSLCert` flag to PWADevServer configuration. PWADevServer will no longer try to create or retrieve a trusted SSL certificate unless `provideSSLCert: true` is in its configuration in `webpack.config.js`. - Modifies custom domain name creation strategy to ensure uniqueness based on a hash of the full local path, rather than using the local flat file database. We created these features for the needs of the developer working on several PWAs at once on their local machine, so that they don't have to set up manual SSL every time, and they have no conflicts with Service Workers. This could be considered "bonus functionality", as it's not critical to the setup of a minimum viable PWA. It was meant to establish our focus on developer experience, and articulate the parts of developer setup that PWA Studio can "own". *However, we soon learned that we could not maintain all scenarios for automated setup and continue to make progress with shopper-facing features*. We still really want to support and automate all of these scenarios, but for now, our implementations are a hindrance and we are turning them off by default. fixup: Documentation edits from PR feedback * chore: manually set version 1.1.0 and lerna fix (#305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[x] Bugfix
[ ] Test for existing code
[ ] Documentation
Summary
Check if
Error.captureStackTraceexists before calling it.When this pull request is merged, it will...
Additional information
Fixes #287