[feature]: ErrorView

[sirugh]

Description

Goal: A generic error view component that handles some basic styling. Should take props allowing for customization, and provide defaults.

Also in this PR:

• Cleanup of unused components
• Refactor of ErrorView and NotFound into single component.
• Fixed some Storybook issues, namely global styles being applied and fonts not being imported.

Related Issue

Closes PWA-1032.

Acceptance

Verification Stakeholders

Specification

Verification Steps

1. Check each of the updated page types and ensure functionality in non-error state.
2. On each of the page types, cause error to be thrown. Simplest way is to block specific data GQL request for that component. Observe that the error view is shown as expected, for that page. Some may have custom messages, others will show default messages.
3. Go to a non-existent route ie https://pr-2936.pwa-venia.com/foo. It should render the error view.

Screenshots / Screen Captures (if appropriate)

Checklist

• I have added tests to cover my changes, if necessary.
• I have added translations for new strings, if necessary.
• I have updated the documentation accordingly, if necessary.

[PWAStudioBot]

	Messages
📖	Associated JIRA tickets: PWA-1032.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against ff34cea

[schensley]

@sirugh thanks for the work on this. UX approved.

[revanth0212]

Nice work buddy. Much needed feature.

[supernova-at]

QA

The UseCmsPage talon does return an error when the GraphQL query fails, but the CMS component itself never looks at that error when determining how to render.

As a result, if the cmsPage query fails, the homepage forever shows the page loading indicator instead of this error message.

Should this logic be fixed in this PR?

[sirugh]

As a result, if the cmsPage query fails, the homepage forever shows the page loading indicator instead of this error message.

This is now remedied by changing shouldShowLoadingIndicator to be loading && !data, so it only shows when the loading boolean from the query hook is true. Once something is returned by the network call we either render the content (hasContent) or we pass rendering responsibility to the child, categoryList component, which will now render the error view if necessary.

I opted not to handle the error state for cmsPage as that's a little out of scope of this work.