[feature]: Add option to use custom https certificates with buildpack

[arturtreiberg]

Description

Added two extra env variable definitions for custom https certificate key and cert paths. Also updated buildpack serve function to add https if custom cert paths are present in the configuration

Related Issue

Closes #2945

Acceptance

Verification Stakeholders

Specification

Verification Steps

1. Add .env variable CUSTOM_HTTPS_KEY with absolute file path to the key file
2. Add .env variable CUSTOM_HTTPS_CERT with absolute file path to the cert file
3. Run buildpack serve .

Checklist

• I have added tests to cover my changes, if necessary.
• I have added translations for new strings, if necessary.
• I have updated the documentation accordingly, if necessary.

[PWAStudioBot]

	Messages
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against a0fdc3e

[jimbo]

@arturtreiberg Hello, thanks for your contribution! Seems like a natural addition.

How can we test this? Would like to verify that it works. A couple of unit tests would also be a good idea; let me know if I can help there.

[arturtreiberg]

Hey @jimbo, sorry for such a late answer.

So testing wise, just adding these .env variables as described in the verification steps above does the trick. After the variables are added, by running yarn buildpack serve . does the trick and the https upward server will be started. Logger message should also say that custom certificates are provided.

Unit test wise, I would have to investigate it a little to see how can this be tested and I'm not sure when I will have the time for that :/ but I'm gonna take a look at what I can do

[sirugh]

I think this is really close - just a small addition requested. Also, if you're able to add some tests that would be very helpful.

Thanks for your contribution!

[arturtreiberg]

I think this is really close - just a small addition requested. Also, if you're able to add some tests that would be very helpful.

Thanks for your contribution!

[jimbo]

Great work, and thanks for adding tests. This works for me, recommend moving to QA. 👍

stale review

[dpatil-magento]

QA Approved