-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA-1101] Add support for Configurable Product Image Setting #2958
Merged
dpatil-magento
merged 22 commits into
magento:develop
from
magento-obsessive-owls:PWA-1101-alt
Jan 21, 2021
Merged
[PWA-1101] Add support for Configurable Product Image Setting #2958
dpatil-magento
merged 22 commits into
magento:develop
from
magento-obsessive-owls:PWA-1101-alt
Jan 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dpatil-magento
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on #2909
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
Jan 21, 2021
eug123
added
the
version: Major
This changeset includes incompatible API changes and its release necessitates a Major version bump.
label
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:peregrine
pkg:venia-ui
Progress: done
version: Major
This changeset includes incompatible API changes and its release necessitates a Major version bump.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recreated from #2909
As a admin user, I would like the ability to change settings in the admin panel to control the configurable product image, and view it in my Venia storefront.
Admin Config Settings:
Stores > Configuration > Sales > Checkout > Shopping Cart > Configurable Product Image
Related Issue
Closes https://jira.corp.magento.com/browse/PWA-1101
Acceptance
Verification Stakeholders
@dpatil-magento
@sirugh
Specification
Verification Steps
Stores > Configuration > Sales > Checkout > Shopping Cart > Configurable Product Image
Screenshots / Screen Captures (if appropriate)
Checklist