Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-1101] Add support for Configurable Product Image Setting #2958

Merged
merged 22 commits into from
Jan 21, 2021

Conversation

eug123
Copy link
Contributor

@eug123 eug123 commented Jan 21, 2021

Description

Recreated from #2909

As a admin user, I would like the ability to change settings in the admin panel to control the configurable product image, and view it in my Venia storefront.

Admin Config Settings:

Stores > Configuration > Sales > Checkout > Shopping Cart > Configurable Product Image

Related Issue

Closes https://jira.corp.magento.com/browse/PWA-1101

Acceptance

Verification Stakeholders

@dpatil-magento
@sirugh

Specification

Verification Steps

  1. Change admin configuration setting for Stores > Configuration > Sales > Checkout > Shopping Cart > Configurable Product Image
  2. Save configuration and navigates to the Venia storefront
  3. Add a Configurable Product to Cart and verify that product thumbnail corresponds admin configuration setting
  4. Verify product thumbnail on Shopping Cart page
  5. Verify product thumbnail on Checkout review page
  6. Verify product thumbnail on Order Confirmation page
  7. Verify product thumbnail on Order History page

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

eug123 and others added 22 commits November 18, 2020 07:33
@PWAStudioBot
Copy link
Contributor

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-1101.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 4fd88b9

@dpatil-magento dpatil-magento self-requested a review January 21, 2021 16:07
Copy link
Contributor

@dpatil-magento dpatil-magento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on #2909

@eug123 eug123 added the version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. label Jan 21, 2021
@dpatil-magento dpatil-magento merged commit 9e54fc7 into magento:develop Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants