-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 17 upgrade #2962
React 17 upgrade #2962
Conversation
|
Ignore the tests for now. The new version of |
There is a huge change in the I'll see if I can mock them but since this is an internal object inside of the react's huge code base, no guarantees 🤞 . |
I suggest using Also, I believe this must be a major release for us, not a minor. There's no way someone could reasonably pull these changes without disruption. |
…on/creditCard.js Co-authored-by: Andy Terranova <13182778+supernova-at@users.noreply.github.com>
This is 👍 but Danger is failing - looks like you just need to run |
QA Approved. |
Description
Upgraded React to 17.0.1
Upgraded informed to 3.27.0
Note: Tagging this as a minor change because it is not a breaking change.
Related Issue
Closes PWA-1040
Verification Stakeholders
@dpatil-magento
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist