Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: allow blob: types for style-src #2985

Merged
merged 4 commits into from
Feb 17, 2021

Conversation

mrbash
Copy link
Contributor

@mrbash mrbash commented Feb 2, 2021

Fix issue #2979

Description

Added 'blob' keyword to veniaSecurityHeaders default template, enabling the load of blob stylesheet contents under CSP constraints.

Related Issue

Closes #2979

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. yarn build
  2. yarn start
  3. verify that blob stylesheet is loading without browser csp errors

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@mrbash mrbash marked this pull request as ready for review February 2, 2021 17:55
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 2, 2021

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against ca975ca

Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Verified using my local instance.

@sirugh sirugh changed the title Fix issue #2979 [feature]: allow blob: types for style-src Feb 3, 2021
@sirugh
Copy link
Contributor

sirugh commented Feb 9, 2021

@mrbash would you mind signing the Adobe CLA? We need that before we can merge your PR. Just click the "Details" next to the Adobe CLA check below.

@mrbash
Copy link
Contributor Author

mrbash commented Feb 9, 2021

@mrbash would you mind signing the Adobe CLA? We need that before we can merge your PR. Just click the "Details" next to the Adobe CLA check below.

@sirugh
Done!

@dpatil-magento dpatil-magento merged commit 70cf1e0 into magento:develop Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Refused to load the stylesheet because it violates the following Content Security Policy
4 participants