Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-1030] Merge Cart does not update mini cart if auth user has same simple product already added #2996

Merged
merged 3 commits into from
Feb 11, 2021

Conversation

tjwiebell
Copy link
Contributor

@tjwiebell tjwiebell commented Feb 5, 2021

Description

URL - [https://develop.pwa-venia.com/]

Steps - 

  1. Login as Auth user
  2. add a simple product or config product to cart
  3. Sign out from account.
  4. Now add same simple or config product with same configs to gues cart
  5. Now login to as Auth user again

Expected - Mini cart count should update and if user open mini cart it should show updated counts.

Actual - Mini cart count does not update. 

Note - 

  1. Cart page works fine
  2. If user does browser refresh then mini cart updates.
  3. Works fine if guest cart has any item other than auth cart has.

Related Issue

  • [PWA-1030] Merge Cart does not update mini cart if auth user has same simple product already added

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Run through reproduction steps, verify that counts are now accurate (compare to counts after refresh)

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@tjwiebell tjwiebell added the version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. label Feb 5, 2021
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 5, 2021

Messages
📖

Associated JIRA tickets: PWA-1030.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against b9b407b

Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed this isn't working right now. I followed verification steps on a simple product, https://pr-2996.pwa-venia.com/silver-amor-bangle-set.html, and the cart trigger did not update to "2" nor does the "qty" in the cart. What is odd is that the cart query for fetching the post-merge details shows the correct info, so it seems the cache is not updating.

Image from Gyazo

@tjwiebell tjwiebell force-pushed the tommy/merge-carts-item-count branch from fb5dc8e to 605c764 Compare February 5, 2021 19:12
@tjwiebell tjwiebell requested a review from sirugh February 5, 2021 19:19
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's working!

@dpatil-magento
Copy link
Contributor

QA Approved

@dpatil-magento dpatil-magento merged commit 3902295 into develop Feb 11, 2021
@dpatil-magento dpatil-magento deleted the tommy/merge-carts-item-count branch February 11, 2021 16:47
@sirugh sirugh mentioned this pull request Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants