Null check for element styling #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
eug123
previously approved these changes
Feb 26, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
Signed-off-by: sirugh <rugh@adobe.com>
sirugh
approved these changes
Mar 2, 2021
jimbo
approved these changes
Mar 2, 2021
| @@ -10,7 +10,7 @@ import parseStorageHtml from './parseStorageHtml'; | |||
| * @constructor | |||
| */ | |||
| export default function PageBuilder({ html, classes }) { | |||
| const data = parseStorageHtml(html); | |||
| const data = useMemo(() => parseStorageHtml(html), [html]); | |||
jimbo
added
the
version: Patch
|
QA Approved. @rycastaneda Please sign Adobe CLA https://github.com/magento/pwa-studio/pull/3016/checks?check_run_id=2071055563, I won't be able to merge until the CI check turns green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #3013
Description
Null check for element styling
Related Issue
Closes #3013
Acceptance
Verification Stakeholders
Specification
Verification Steps