Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1617 - Fetch store name from the GraphQL server at compile time #3019

Merged
merged 17 commits into from
Mar 9, 2021
Merged

#1617 - Fetch store name from the GraphQL server at compile time #3019

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
69eed60
#1617 - Fetch store name from the GraphQL server at compile time
Feb 19, 2021
0d89ec4
Merge branch 'develop' into 1617-fetch-store-name-from-graphql-at-bui…
Feb 19, 2021
2bc69ae
format the code with prettier
Feb 19, 2021
71e9263
remove unnecessary declarations
Feb 20, 2021
139b251
Simplify the process of finding the available store
Feb 22, 2021
ee64ffb
Simplify the assignment of current store name
Feb 22, 2021
a17b53c
Merge branch 'develop' into 1617-fetch-store-name-from-graphql-at-bui…
Feb 22, 2021
9bb320e
Fix destructure syntax
sirugh Feb 22, 2021
30782a0
prettier
sirugh Feb 22, 2021
f3b36a5
availableStore -> availableStores
revanth0212 Feb 22, 2021
22122c8
Use runtime store name fetch in a new TitleWithStore component.
sirugh Feb 25, 2021
577c2bf
StoreTitle
sirugh Feb 25, 2021
9d9d70f
Fix tests
sirugh Mar 2, 2021
0ae600e
Fix error view rendering when data was still returned
sirugh Mar 4, 2021
1bfd9da
fix test snap
sirugh Mar 4, 2021
8b183a9
Merge remote-tracking branch 'origin/develop' into 1617-fetch-store-n…
sirugh Mar 4, 2021
b2b724f
Merge branch 'develop' into 1617-fetch-store-name-from-graphql-at-bui…
dpatil-magento Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/pwa-buildpack/lib/queries/getStoreConfigData.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ query {
code
locale
secure_base_media_url
store_name
}
}
17 changes: 16 additions & 1 deletion packages/venia-concept/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,20 @@ module.exports = async env => {
const storeConfigData = await getStoreConfigData();
const { availableStores } = await getAvailableStoresConfigData();

/**
* Loop the available stores when there is provided STORE_VIEW_CODE
* in the .env file, because should set the store name from the
* given store code instead of the default one.
*/
const availableStore = process.env.STORE_VIEW_CODE
? availableStores.find(
store => store.code === process.env.STORE_VIEW_CODE
)
: undefined;
vasilii-b marked this conversation as resolved.
Show resolved Hide resolved

global.MAGENTO_MEDIA_BACKEND_URL = mediaUrl;
global.LOCALE = storeConfigData.locale.replace('_', '-');
global.STORE_NAME = storeConfigData.store_name;
vasilii-b marked this conversation as resolved.
Show resolved Hide resolved
global.AVAILABLE_STORE_VIEWS = availableStores;

const possibleTypes = await getPossibleTypes();
Expand All @@ -63,7 +75,10 @@ module.exports = async env => {
* the globals object in jest.config.js.
*/
POSSIBLE_TYPES: JSON.stringify(possibleTypes),
STORE_NAME: JSON.stringify('Venia'),
STORE_NAME:
process.env.STORE_VIEW_CODE && availableStore
? JSON.stringify(availableStore.store_name)
: JSON.stringify(global.STORE_NAME),
vasilii-b marked this conversation as resolved.
Show resolved Hide resolved
STORE_VIEW_CODE: process.env.STORE_VIEW_CODE
? JSON.stringify(process.env.STORE_VIEW_CODE)
: JSON.stringify(storeConfigData.code),
Expand Down