Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-1001: Exclude venia-ui/lib/components/Checkout from Coverage Report #3023

Merged
merged 1 commit into from
Feb 25, 2021
Merged

PWA-1001: Exclude venia-ui/lib/components/Checkout from Coverage Report #3023

merged 1 commit into from
Feb 25, 2021

Conversation

eug123
Copy link
Contributor

@eug123 eug123 commented Feb 24, 2021

Description

Exclude this venia-ui/lib/components/Checkout folder from the coverage report

Related Issue

Closes #PWA-1001.

Acceptance

Any developer

Verification Stakeholders

Any developer

Specification

Verification Steps

  1. Run yarn test
  2. Make sure venia-ui/lib/components/Checkout is not present in the coverage report.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 24, 2021 •
edited
Loading

Messages
📖

Associated JIRA tickets: PWA-1001.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 177d613

@eug123 eug123 added the version: Patch This changeset includes backwards compatible bug fixes. label Feb 24, 2021
@anthoula anthoula merged commit 05bb83f into magento:develop Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsroettig larsroettig larsroettig approved these changes

@anthoula anthoula anthoula approved these changes

Assignees

@anthoula anthoula

@larsroettig larsroettig

Labels
Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eug123 @PWAStudioBot @anthoula @larsroettig