Increase test coverage for packages/peregrine/lib/talons/CheckoutPage
#3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalcaben
added
the
version: Patch
|
|
I'm seeing some test failures when running |
|
The untestable places seem like refactor targets if they're easy enough to fix up and the logic is identical. What do you thnink? |
larsroettig
previously approved these changes
Feb 28, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
sirugh
previously approved these changes
Mar 1, 2021
Comment on lines
29
to
42
| useMutation.mockImplementation(query => { | ||
| let result = [jest.fn(), { error: null }]; | ||
|
|
||
| switch (query) { | ||
| case 'createAccountMutation': | ||
| result = [mockCreateAccount, { error: null }]; | ||
| break; | ||
| case 'signInMutation': | ||
| result = [mockSignIn, { error: null }]; | ||
| break; | ||
| } | ||
|
|
||
| return result; | ||
| }); |
There was a problem hiding this comment.
Did you try using the new query mocking approach, like here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase coverage for files under
packages/peregrine/lib/talons/CheckoutPageNOTE:
The uncovered lines in the report represent branching logic paths that appear to be unreachable.
Line 12 in
CheckoutPage/AddressBook/useAddressCard.js: Address cannot be undefined because the destructuring in Line 5 would cause an error before it could reach Line 12.Line 132 in
CheckoutPage/PaymentInformation/useCreditCard.js: Cannot test the (false||true) path for this line since the only timedropInLoadingis set tofalse, thestepNumberis always set to 0.Related Issue
Closes PWA-996
Acceptance
any developer
Verification Stakeholders
any developer
Specification
Verification Steps
yarn test --collectCoverageFrom="packages/peregrine/lib/talons/CheckoutPage/**/*.js" packages/peregrine/lib/talons/CheckoutPage/Screenshots / Screen Captures (if appropriate)
Checklist