Update asyncActions.js #3026
Update asyncActions.js #3026
Conversation
The cart context should get the details if any error occurs
LogERROR ON TASK: prettierCheck ERROR ON TASK: unitTests If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section. |
|
Hello @indranil-m, would you please open an issue describing the problem and link it here as the PR template suggests? We will also need repro steps for the bug (what is wrong and how did you get it to occur) as well as steps we can use to check that this code fixes that problem. |
sirugh
added
the
requires followup
|
Hi,
The issue is whenever some cart related error occurs like qty out of max
limit or out of scope etc at that time cartdetails will raise an exception
and it will go to error block.but if we do errorPolicy all then it will
throw the data in details object.otherwise details object will contain cart
id and in pwa we cant show the cart data
…On Fri, 26 Feb 2021, 20:43 Stephen, ***@***.***> wrote:
Hello @indranil-m <https://github.com/indranil-m>, would you please open
an issue describing the problem and link it here as the PR template
suggests? We will also need repro steps for the bug (what is wrong and how
did you get it to occur) as well as steps we can use to check that this
code fixes that problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALEP7DDWU7LJZVRD5F234TTA63CLANCNFSM4YINIJPA>
.
|
| @@ -347,10 +347,11 @@ export const getCartDetails = payload => { | |||
| try { | |||
| const { data } = await fetchCartDetails({ | |||
| variables: { cartId }, | |||
| fetchPolicy: 'network-only' | |||
| fetchPolicy: 'no-cache', | |||
There was a problem hiding this comment.
This was switched to network-only very recently to fix a bug: #2996
If you use no-cache then the mini cart will get out of date.
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
|
Closing this. In the future please use the BUG issue template to report any issues you might have found. This helps us assess and prioritize issues that arise. In this case, because there are no repro steps or an "expected vs actual", I can't verify. |
The cart context should get the details if any error occurs
Description
TODO: Describe your changes in detail here.
Related Issue
Closes #ISSUE_NUMBER.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist