Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CMS header line height #3032

Merged
merged 3 commits into from
Mar 4, 2021
Merged

Fixes CMS header line height #3032

merged 3 commits into from
Mar 4, 2021

Conversation

supernova-at
Copy link
Contributor

Description

This PR adds a line-height rule to the CMS RootComponent CSS so that when headings are displayed they have enough space to render. The line-height value of 1.25em is consistent with other pages in the storefront application.

Related Issue

Closes PWA-714.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Find a way to populate the content_heading field of the CMS page. I had to modify cms.js lines 41 and 42 manually locally
  2. yarn watch:venia
  3. Verify that the heading content appears and is displayed correctly

Screenshots / Screen Captures (if appropriate)

Screen Shot 2021-03-02 at 12 42 12 PM

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 2, 2021
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Mar 2, 2021

Messages
📖

Associated JIRA tickets: PWA-714.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against bf38a2c

@dpatil-magento dpatil-magento merged commit a66abcc into develop Mar 4, 2021
@dpatil-magento dpatil-magento deleted the supernova/cms_header branch March 4, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants