Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring CE and EE gql files based on Mangeto edition. #3047

Merged
merged 6 commits into from
Mar 18, 2021

Conversation

revanth0212
Copy link
Contributor

Description

Ignore CE and EE files based on env.MAGENTO_BACKEND_EDITION.

Related Issue

Closes PWA-843

Acceptance

yarn run build:dev should work fine.

Verification Stakeholders

@dpatil-magento

Verification Steps

  1. Checkout this branch.
  2. Use a valid CE Magento backend and set MAGENTO_BACKEND_EDITION to CE. Run yarn build:dev, it should work fine.
  3. Use a valid EE Magento backend and set MAGENTO_BACKEND_EDITION to EE. Run yarn build:dev, it should work fine.

Screenshots / Screen Captures (if appropriate)

image

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@revanth0212 revanth0212 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Mar 5, 2021
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Mar 5, 2021

Messages
📖

Associated JIRA tickets: PWA-843.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against e82cb51

tjwiebell
tjwiebell previously approved these changes Mar 12, 2021
Copy link
Contributor

@tjwiebell tjwiebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 could use a test but not blocking approval.

@dpatil-magento
Copy link
Contributor

@revanth0212 I still see error after setting MAGENTO_BACKEND_EDITION=CE and using CE backend then running yarn build:dev

  18:9  error  Cannot query field "giftCardAccount" on type "Query"                                                                          graphql/template-strings
  32:9  error  Cannot query field "applyGiftCardToCart" on type "Mutation". Did you mean "applyCouponToCart"?                                graphql/template-strings
  51:9  error  Cannot query field "removeGiftCardFromCart" on type "Mutation". Did you mean "removeItemFromCart" or "removeCouponFromCart"?  graphql/template-strings

packages/venia-concept/.graphqlconfig Outdated Show resolved Hide resolved
tjwiebell
tjwiebell previously approved these changes Mar 17, 2021
Copy link
Contributor

@tjwiebell tjwiebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 just needs tests and this is ready to go.

@dpatil-magento
Copy link
Contributor

QA Approved.

@dpatil-magento dpatil-magento merged commit 595c53d into develop Mar 18, 2021
@dpatil-magento dpatil-magento deleted the revanth/validate_queries_ce_ee_fix branch March 18, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants