-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring CE and EE gql files based on Mangeto edition. #3047
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 could use a test but not blocking approval.
@revanth0212 I still see error after setting
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 just needs tests and this is ready to go.
QA Approved. |
Description
Ignore CE and EE files based on
env.MAGENTO_BACKEND_EDITION
.Related Issue
Closes PWA-843
Acceptance
yarn run build:dev
should work fine.Verification Stakeholders
@dpatil-magento
Verification Steps
yarn build:dev
, it should work fine.yarn build:dev
, it should work fine.Screenshots / Screen Captures (if appropriate)
Checklist