[PWA-632] My Account: Wishlist: Actions Menu and Edit Flow #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create new dialog modals for list actions, and edit wishlist
- add GQL for updateWishlist
- add new dialogs to wishlist page - add button handlers for modals
- add modal styles
- pass id from mockdata to talon - add error handling for updateWishlist - pre-populate edit modal values - add visibility field to customer wishlist query - add visibility field to mock data
- use error message from mutation - update translations - remove generic error handling - update error message styles
anthoula
added
the
version: Minor
|
- update modal styles
- add loading state while updateWishlist is in progress
- add test coverage for new dialogs
tjwiebell
suggested changes
Mar 12, 2021
packages/venia-ui/lib/components/WishlistPage/wishlistEditFavoritesListDialog.js
Outdated
Show resolved
Hide resolved
packages/venia-ui/lib/components/WishlistPage/__tests__/wishlistEditFavoritesListDialog.spec.js
Outdated
Show resolved
Hide resolved
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
- remove unnecessary deps - use public interfaces - add names to mocks
- update signature - mock mutation - name function mocks - update snapshots
sirugh
reviewed
Apr 1, 2021
- clarify check for name field
- create new actionMenu component and hook to separate EE functionality
sirugh
reviewed
Apr 7, 2021
| refetchQueries: [{ query: getCustomerWishlistQuery }], | ||
| awaitRefetchQueries: true | ||
| }); | ||
| await setCurrentDialog(dialogs.NONE); |
There was a problem hiding this comment.
As far as I know this is async but awaiting doesn't do anything. May as well remove the await.
sirugh
previously approved these changes
Apr 7, 2021
There was a problem hiding this comment.
This is much cleaner now. The wishlist.js component no longer has a bunch of extra code in the talon. Instead, that responsibility is passed down to the backend-specific component, so the CE wishlist page will be much lighter in that respect.
Good job! I thought it would be more difficult :)
- update tests for new ActionMenu component
- remove unnecessary await
sirugh
previously approved these changes
Apr 7, 2021
- remove mutation in test
sirugh
approved these changes
Apr 8, 2021
|
QA Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ability to edit a wishlist's name and visibility (public or private). Add additional action menu panel.
Related Issue
PWA-632
Acceptance
Verification Stakeholders
@dpatil-magento
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist