Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update comment on cmsPage talon to reflect why we compare against default string #3062

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Mar 17, 2021

Adds the context back to why we use this string comparison.

See #3033.

check against the default cms string

Signed-off-by: sirugh <rugh@adobe.com>
@PWAStudioBot
Copy link
Contributor

Fails
🚫 A version label is required. A maintainer must add one.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫 Missing "Description" section. Please add it back, with detail.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against a705f47

@jcalcaben jcalcaben merged commit 49e7891 into develop Mar 17, 2021
@sirugh sirugh deleted the rugh/fix-cms-comment branch April 26, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants